RE: [PATCH v1 0/2] vfio/pci: expose device's PASID capability to VMs

Tian, Kevin
2020-03-31T06:35:18Z

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Sunday, March 22, 2020 8:33 PM
>
> From: Liu Yi L <yi.l.liu@intel.com>
>
> Shared Virtual Addressing (SVA), a.k.a, Shared Virtual Memory (SVM) on
> Intel platforms allows address space sharing between device DMA and
> applications. SVA can reduce programming complexity and enhance security.
>
> To enable SVA, device needs to have PASID capability, which is a key
> capability for SVA. This patchset exposes the device's PASID capability
> to guest instead of hiding it from guest.
>
> The second patch emulates PASID capability for VFs (Virtual Function) since
> VFs don't implement such capability per PCIe spec. This patch emulates such
> capability and expose to VM if the capability is enabled in PF (Physical
> Function).
>
> However, there is an open for PASID emulation. If PF driver disables PASID
> capability at runtime, then it may be an issue. e.g. PF should not disable
> PASID capability if there is guest using this capability on any VF related
> to this PF. To solve it, may need to introduce a generic communication
> framework between vfio-pci driver and PF drivers. Please feel free to give
> your suggestions on it.

I'm not sure how this is addressed on bate metal today, i.e. between normal
kernel PF and VF drivers. I look at pasid enable/disable code in intel-iommu.c.
There is no check on PF/VF dependency so far. The cap is toggled when
attaching/detaching the PF to its domain. Let's see how IOMMU guys
respond, and if there is a way for VF driver to block PF driver from disabling
the pasid cap when it's being actively used by VF driver, then we may
leverage the same trick in VFIO when emulation is provided to guest.

Thanks
Kevin

>
> Regards,
> Yi Liu
>
> Changelog:
> - RFC v1 -> Patch v1:
> Add CONFIG_PCI_ATS #ifdef control to avoid compiling error.
>
> Liu Yi L (2):
> vfio/pci: Expose PCIe PASID capability to guest
> vfio/pci: Emulate PASID/PRI capability for VFs
>
> drivers/vfio/pci/vfio_pci_config.c | 327
> ++++++++++++++++++++++++++++++++++++-
> 1 file changed, 324 insertions(+), 3 deletions(-)
>
> --
> 2.7.4