From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
Joerg Roedel <joro@8bytes.org>
Subject: Re: [RFC PATCH] KVM: SVM: Use do_machine_check to pass MCE to the host
Date: Mon, 13 Apr 2020 14:03:20 -0700 [thread overview]
Message-ID: <20200413210320.GA21204@linux.intel.com> (raw)
In-Reply-To: <20200411153627.3474710-1-ubizjak@gmail.com>
On Sat, Apr 11, 2020 at 05:36:27PM +0200, Uros Bizjak wrote:
> Use do_machine_check instead of INT $12 to pass MCE to the host,
> the same approach VMX uses.
>
> On a related note, there is no reason to limit the use of do_machine_check
> to 64 bit targets, as is currently done for VMX. MCE handling works
> for both target families.
...
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index 8959514eaf0f..01330096ff3e 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -4572,7 +4572,7 @@ static int handle_rmode_exception(struct kvm_vcpu *vcpu,
> */
> static void kvm_machine_check(void)
> {
> -#if defined(CONFIG_X86_MCE) && defined(CONFIG_X86_64)
> +#if defined(CONFIG_X86_MCE)
This VMX change needs to be a separate patch, and it arguably warrants:
Cc: stable@vger.kernel.org
Fixes: a0861c02a981 ("KVM: Add VT-x machine check support")
> struct pt_regs regs = {
> .cs = 3, /* Fake ring 3 no matter what the guest ran on */
> .flags = X86_EFLAGS_IF,
> --
> 2.25.2
>
next prev parent reply other threads:[~2020-04-13 21:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 15:36 [RFC PATCH] KVM: SVM: Use do_machine_check to pass MCE to the host Uros Bizjak
2020-04-13 21:03 ` Sean Christopherson [this message]
2020-04-14 8:28 ` Paolo Bonzini
2020-04-14 8:38 ` Uros Bizjak
2020-04-14 8:50 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413210320.GA21204@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).