From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Simon Smith <brigidsmith@google.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com,
Jim Mattson <jmattson@google.com>,
Peter Shier <pshier@google.com>,
Krish Sadhukhan <krish.sadhukhan@oracle.com>
Subject: Re: [kvm-unit-tests RESEND PATCH] x86: gtests: add new test for vmread/vmwrite flags preservation
Date: Mon, 13 Apr 2020 16:50:39 -0700 [thread overview]
Message-ID: <20200413235039.GK21204@linux.intel.com> (raw)
In-Reply-To: <20200413172432.70180-1-brigidsmith@google.com>
s/gtest/nVMX for the shortlog. I thought this was somehow related to the
Google Test framework, especially coming from a @google.com address.
On Mon, Apr 13, 2020 at 10:24:32AM -0700, Simon Smith wrote:
> This commit adds new unit tests for commit a4d956b93904 ("KVM: nVMX:
> vmread should not set rflags to specify success in case of #PF")
>
> The two new tests force a vmread and a vmwrite on an unmapped
> address to cause a #PF and verify that the low byte of %rflags is
> preserved and that %rip is not advanced. The cherry-pick fixed a
> bug in vmread, but we include a test for vmwrite as well for
> completeness.
I think some of Google's process is bleeding into kvm-unit-tests, I'm pretty
sure the aforementioned commit wasn't cherry-picked into Paolo's tree. :-D
> Before the aforementioned commit, the ALU flags would be incorrectly
> cleared and %rip would be advanced (for vmread).
next prev parent reply other threads:[~2020-04-13 23:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 17:24 [kvm-unit-tests RESEND PATCH] x86: gtests: add new test for vmread/vmwrite flags preservation Simon Smith
2020-04-13 23:50 ` Sean Christopherson [this message]
2020-04-13 23:52 ` Jim Mattson
2020-04-13 23:55 ` Jim Mattson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413235039.GK21204@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=brigidsmith@google.com \
--cc=jmattson@google.com \
--cc=krish.sadhukhan@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=pshier@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox