From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD9C0C2BB85 for ; Tue, 14 Apr 2020 21:15:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3358206A2 for ; Tue, 14 Apr 2020 21:15:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391753AbgDNVPC (ORCPT ); Tue, 14 Apr 2020 17:15:02 -0400 Received: from mx2.suse.de ([195.135.220.15]:59768 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732367AbgDNVPA (ORCPT ); Tue, 14 Apr 2020 17:15:00 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 45390ABBE; Tue, 14 Apr 2020 21:14:57 +0000 (UTC) Date: Tue, 14 Apr 2020 14:12:43 -0700 From: Davidlohr Bueso To: Paolo Bonzini Cc: tglx@linutronix.de, bigeasy@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, torvalds@linux-foundation.org, will@kernel.org, joel@joelfernandes.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paul Mackerras , kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, Davidlohr Bueso Subject: Re: [PATCH 3/4] kvm: Replace vcpu->swait with rcuwait Message-ID: <20200414211243.7vehybdrvbzmbduu@linux-p48b> References: <20200324044453.15733-1-dave@stgolabs.net> <20200324044453.15733-4-dave@stgolabs.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, 25 Mar 2020, Paolo Bonzini wrote: >On 24/03/20 05:44, Davidlohr Bueso wrote: >> diff --git a/arch/mips/kvm/mips.c b/arch/mips/kvm/mips.c >> index 71244bf87c3a..e049fcb3dffb 100644 >> --- a/arch/mips/kvm/mips.c >> +++ b/arch/mips/kvm/mips.c >> @@ -290,8 +290,7 @@ static enum hrtimer_restart kvm_mips_comparecount_wakeup(struct hrtimer *timer) >> kvm_mips_callbacks->queue_timer_int(vcpu); >> >> vcpu->arch.wait = 0; >> - if (swq_has_sleeper(&vcpu->wq)) >> - swake_up_one(&vcpu->wq); >> + rcuwait_wake_up(&vcpu->wait) > >This is missing a semicolon. (KVM MIPS is known not to compile and will >be changed to "depends on BROKEN" in 5.7). Do you want me to send another version with this fix or do you prefer fixing it when/if picked up? Thanks, Davidlohr