From: Janosch Frank <frankja@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: thuth@redhat.com, linux-s390@vger.kernel.org, david@redhat.com,
borntraeger@de.ibm.com, cohuck@redhat.com
Subject: [PATCH v2 07/10] s390x: smp: Use full PSW to bringup new cpu
Date: Thu, 23 Apr 2020 05:10:10 -0400 [thread overview]
Message-ID: <20200423091013.11587-8-frankja@linux.ibm.com> (raw)
In-Reply-To: <20200423091013.11587-1-frankja@linux.ibm.com>
Up to now we ignored the psw mask and only used the psw address when
bringing up a new cpu. For DAT we need to also load the mask, so let's
do that.
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
---
lib/s390x/smp.c | 2 ++
s390x/cstart64.S | 3 ++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/s390x/smp.c b/lib/s390x/smp.c
index 3f86243..6ef0335 100644
--- a/lib/s390x/smp.c
+++ b/lib/s390x/smp.c
@@ -202,6 +202,8 @@ int smp_cpu_setup(uint16_t addr, struct psw psw)
cpu->stack = (uint64_t *)alloc_pages(2);
/* Start without DAT and any other mask bits. */
+ cpu->lowcore->sw_int_psw.mask = psw.mask;
+ cpu->lowcore->sw_int_psw.addr = psw.addr;
cpu->lowcore->sw_int_grs[14] = psw.addr;
cpu->lowcore->sw_int_grs[15] = (uint64_t)cpu->stack + (PAGE_SIZE * 4);
lc->restart_new_psw.mask = 0x0000000180000000UL;
diff --git a/s390x/cstart64.S b/s390x/cstart64.S
index ecffbe0..e084f13 100644
--- a/s390x/cstart64.S
+++ b/s390x/cstart64.S
@@ -161,7 +161,8 @@ smp_cpu_setup_state:
lctlg %c0, %c0, GEN_LC_SW_INT_CRS
/* We should only go once through cpu setup and not for every restart */
stg %r14, GEN_LC_RESTART_NEW_PSW + 8
- brasl %r14, %r14
+ larl %r14, 0f
+ lpswe GEN_LC_SW_INT_PSW
/* If the function returns, just loop here */
0: j 0
--
2.25.1
next prev parent reply other threads:[~2020-04-23 9:11 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 9:10 [PATCH v2 00/10] s390x: smp: Improve smp code part 2 Janosch Frank
2020-04-23 9:10 ` [PATCH v2 01/10] s390x: smp: Test all CRs on initial reset Janosch Frank
2020-04-23 15:39 ` David Hildenbrand
2020-04-24 9:33 ` [PATCH v3] " Janosch Frank
2020-04-24 10:03 ` David Hildenbrand
2020-04-23 9:10 ` [PATCH v2 02/10] s390x: smp: Dirty fpc before initial reset test Janosch Frank
2020-04-23 9:10 ` [PATCH v2 03/10] s390x: smp: Test stop and store status on a running and stopped cpu Janosch Frank
2020-04-23 16:03 ` David Hildenbrand
2020-04-23 9:10 ` [PATCH v2 04/10] s390x: smp: Test local interrupts after cpu reset Janosch Frank
2020-04-24 10:07 ` David Hildenbrand
2020-04-24 11:51 ` Janosch Frank
2020-04-23 9:10 ` [PATCH v2 05/10] s390x: smp: Loop if secondary cpu returns into cpu setup again Janosch Frank
2020-04-24 10:08 ` David Hildenbrand
2020-04-23 9:10 ` [PATCH v2 06/10] s390x: smp: Remove unneeded cpu loops Janosch Frank
2020-04-23 9:10 ` Janosch Frank [this message]
2020-04-24 10:09 ` [PATCH v2 07/10] s390x: smp: Use full PSW to bringup new cpu David Hildenbrand
2020-04-24 11:16 ` Janosch Frank
2020-04-24 11:23 ` David Hildenbrand
2020-04-24 11:31 ` Janosch Frank
2020-04-23 9:10 ` [PATCH v2 08/10] s390x: smp: Wait for sigp completion Janosch Frank
2020-04-24 10:11 ` David Hildenbrand
2020-04-24 11:40 ` Janosch Frank
2020-04-29 8:57 ` Janosch Frank
2020-04-29 9:06 ` David Hildenbrand
2020-04-29 9:37 ` Janosch Frank
2020-04-29 9:55 ` David Hildenbrand
2020-04-29 11:21 ` Janosch Frank
2020-04-29 11:47 ` David Hildenbrand
2020-04-29 12:09 ` Janosch Frank
2020-04-29 12:15 ` David Hildenbrand
2020-04-23 9:10 ` [PATCH v2 09/10] s390x: smp: Add restart when running test Janosch Frank
2020-04-24 10:13 ` David Hildenbrand
2020-04-23 9:10 ` [PATCH v2 10/10] s390x: Fix library constant definitions Janosch Frank
2020-04-24 10:13 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423091013.11587-8-frankja@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox