From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, Nitesh Narayan Lal <nitesh@redhat.com>,
Sean Christopherson <sean.j.christopherson@intel.com>
Subject: [kvm-unit-tests PATCH] x86: ioapic: Run physical destination mode test iff cpu_count() > 1
Date: Thu, 23 Apr 2020 12:50:50 -0700 [thread overview]
Message-ID: <20200423195050.26310-1-sean.j.christopherson@intel.com> (raw)
Make test_ioapic_physical_destination_mode() depending on having at
least two CPUs as it sets ->dest_id to '1', i.e. expects CPU0 and CPU1
to exist. This analysis is backed up by the fact that the test was
originally gated by cpu_count() > 1.
Fixes: dcf27dc5b5499 ("x86: Fix the logical destination mode test")
Cc: Nitesh Narayan Lal <nitesh@redhat.com>
Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
---
x86/ioapic.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/x86/ioapic.c b/x86/ioapic.c
index 3106531..f315e4b 100644
--- a/x86/ioapic.c
+++ b/x86/ioapic.c
@@ -504,7 +504,8 @@ int main(void)
test_ioapic_level_tmr(true);
test_ioapic_edge_tmr(true);
- test_ioapic_physical_destination_mode();
+ if (cpu_count() > 1)
+ test_ioapic_physical_destination_mode();
if (cpu_count() > 3)
test_ioapic_logical_destination_mode();
--
2.26.0
next reply other threads:[~2020-04-23 19:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 19:50 Sean Christopherson [this message]
2020-04-23 19:56 ` [kvm-unit-tests PATCH] x86: ioapic: Run physical destination mode test iff cpu_count() > 1 Nitesh Narayan Lal
2020-05-04 16:33 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423195050.26310-1-sean.j.christopherson@intel.com \
--to=sean.j.christopherson@intel.com \
--cc=kvm@vger.kernel.org \
--cc=nitesh@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox