From: Janosch Frank <frankja@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: thuth@redhat.com, linux-s390@vger.kernel.org, david@redhat.com,
borntraeger@de.ibm.com, cohuck@redhat.com
Subject: [PATCH v3] s390x: smp: Test all CRs on initial reset
Date: Fri, 24 Apr 2020 05:33:56 -0400 [thread overview]
Message-ID: <20200424093356.11931-1-frankja@linux.ibm.com> (raw)
In-Reply-To: <2ebdf5d6-74ac-d9e5-d329-29611a5f87cd@redhat.com>
All CRs are set to 0 and CRs 0 and 14 are set to pre-defined values,
so we also need to test 1-13 and 15 for 0.
And while we're at it, let's also set some values to cr 1, 7 and 13, so
we can actually be sure that they will be zeroed.
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
s390x/smp.c | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/s390x/smp.c b/s390x/smp.c
index fa40753..7144c9b 100644
--- a/s390x/smp.c
+++ b/s390x/smp.c
@@ -182,16 +182,28 @@ static void test_emcall(void)
report_prefix_pop();
}
+/* Used to dirty registers of cpu #1 before it is reset */
+static void test_func_initial(void)
+{
+ lctlg(1, 0x42000UL);
+ lctlg(7, 0x43000UL);
+ lctlg(13, 0x44000UL);
+ set_flag(1);
+}
+
static void test_reset_initial(void)
{
struct cpu_status *status = alloc_pages(0);
struct psw psw;
+ int i;
psw.mask = extract_psw_mask();
- psw.addr = (unsigned long)test_func;
+ psw.addr = (unsigned long)test_func_initial;
report_prefix_push("reset initial");
+ set_flag(0);
smp_cpu_start(1, psw);
+ wait_for_flag();
sigp_retry(1, SIGP_INITIAL_CPU_RESET, 0, NULL);
sigp(1, SIGP_STORE_STATUS_AT_ADDRESS, (uintptr_t)status, NULL);
@@ -202,6 +214,10 @@ static void test_reset_initial(void)
report(!status->fpc, "fpc");
report(!status->cputm, "cpu timer");
report(!status->todpr, "todpr");
+ for (i = 1; i <= 13; i++) {
+ report(status->crs[i] == 0, "cr%d == 0", i);
+ }
+ report(status->crs[15] == 0, "cr15 == 0");
report_prefix_pop();
report_prefix_push("initialized");
--
2.25.1
next prev parent reply other threads:[~2020-04-24 9:34 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 9:10 [PATCH v2 00/10] s390x: smp: Improve smp code part 2 Janosch Frank
2020-04-23 9:10 ` [PATCH v2 01/10] s390x: smp: Test all CRs on initial reset Janosch Frank
2020-04-23 15:39 ` David Hildenbrand
2020-04-24 9:33 ` Janosch Frank [this message]
2020-04-24 10:03 ` [PATCH v3] " David Hildenbrand
2020-04-23 9:10 ` [PATCH v2 02/10] s390x: smp: Dirty fpc before initial reset test Janosch Frank
2020-04-23 9:10 ` [PATCH v2 03/10] s390x: smp: Test stop and store status on a running and stopped cpu Janosch Frank
2020-04-23 16:03 ` David Hildenbrand
2020-04-23 9:10 ` [PATCH v2 04/10] s390x: smp: Test local interrupts after cpu reset Janosch Frank
2020-04-24 10:07 ` David Hildenbrand
2020-04-24 11:51 ` Janosch Frank
2020-04-23 9:10 ` [PATCH v2 05/10] s390x: smp: Loop if secondary cpu returns into cpu setup again Janosch Frank
2020-04-24 10:08 ` David Hildenbrand
2020-04-23 9:10 ` [PATCH v2 06/10] s390x: smp: Remove unneeded cpu loops Janosch Frank
2020-04-23 9:10 ` [PATCH v2 07/10] s390x: smp: Use full PSW to bringup new cpu Janosch Frank
2020-04-24 10:09 ` David Hildenbrand
2020-04-24 11:16 ` Janosch Frank
2020-04-24 11:23 ` David Hildenbrand
2020-04-24 11:31 ` Janosch Frank
2020-04-23 9:10 ` [PATCH v2 08/10] s390x: smp: Wait for sigp completion Janosch Frank
2020-04-24 10:11 ` David Hildenbrand
2020-04-24 11:40 ` Janosch Frank
2020-04-29 8:57 ` Janosch Frank
2020-04-29 9:06 ` David Hildenbrand
2020-04-29 9:37 ` Janosch Frank
2020-04-29 9:55 ` David Hildenbrand
2020-04-29 11:21 ` Janosch Frank
2020-04-29 11:47 ` David Hildenbrand
2020-04-29 12:09 ` Janosch Frank
2020-04-29 12:15 ` David Hildenbrand
2020-04-23 9:10 ` [PATCH v2 09/10] s390x: smp: Add restart when running test Janosch Frank
2020-04-24 10:13 ` David Hildenbrand
2020-04-23 9:10 ` [PATCH v2 10/10] s390x: Fix library constant definitions Janosch Frank
2020-04-24 10:13 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424093356.11931-1-frankja@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox