Re: [PATCH v4 0/8] s390x/vfio-ccw: Channel Path Handling [KVM]

Cornelia Huck
2020-05-06T13:59:22Z

On Tue, 5 May 2020 09:00:20 -0400
Eric Farman <farman@linux.ibm.com> wrote:

> On 5/5/20 8:56 AM, Cornelia Huck wrote:
> > On Tue, 5 May 2020 14:27:37 +0200
> > Eric Farman <farman@linux.ibm.com> wrote:

> >>
> >>> One thing though that keeps coming up: do we need any kind of
> >>> serialization? Can there be any confusion from concurrent reads from
> >>> userspace, or are we sure that we always provide consistent data?
> >>
> >> I _think_ this is in good shape, though as suggested another set of
> >> eyeballs would be nice. There is still a problem on the main
> >> interrupt/FSM path, which I'm not attempting to address here.
> >
> > I'll try to think about it some more.

I've convinced myself that the patches do not add any new races on top
of what already might be lurking in the existing code.

>
> Re: interrupt/FSM, I now have two separate patches that each straighten
> things out on their own. And a handful of debug patches that probably
> only make things worse. :) I'll get one/both of those meaningful
> patches sent to the list so we can have that discussion separately from
> this code.

Yes, let's do that on top.

I think that the series looks good now, but I'd still like to see
someone else give it a quick look before I queue it.