Re: [PATCH 07/26] KVM: arm64: Add a level hint to __kvm_tlb_flush_vmid_ipa

Marc Zyngier
2020-05-07T15:13:34Z

On 2020-05-07 16:08, Andrew Scull wrote:
>> -void __hyp_text __kvm_tlb_flush_vmid_ipa(struct kvm_s2_mmu *mmu,
>> phys_addr_t ipa)
>> +void __hyp_text __kvm_tlb_flush_vmid_ipa(struct kvm_s2_mmu *mmu,
>> + phys_addr_t ipa, int level)
>
> The level feels like a good opportunity for an enum to add some
> documentation from the type.

Sure, why not. I'll give it a go.

>
>> static void kvm_tlb_flush_vmid_ipa(struct kvm_s2_mmu *mmu,
>> phys_addr_t ipa)
>> {
>> - kvm_call_hyp(__kvm_tlb_flush_vmid_ipa, mmu, ipa);
>> + kvm_call_hyp(__kvm_tlb_flush_vmid_ipa, mmu, ipa, 0);
>
> With the constants from the next patch brought forward, the magic 0 can
> be given a name, although it's very temporary so..

Yup. To the point where I've now squashed this patch and the following
one together, and moved the constants to the previous patch.

> Otherwise, looks good.

Thanks,

M.
--
Jazz is not dead. It just smells funny...