From: Cornelia Huck <cohuck@redhat.com>
To: Eric Farman <farman@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org,
Halil Pasic <pasic@linux.ibm.com>,
Jason Herne <jjherne@linux.ibm.com>,
Jared Rossi <jrossi@linux.ibm.com>
Subject: Re: [PATCH v4 0/8] s390x/vfio-ccw: Channel Path Handling [KVM]
Date: Wed, 6 May 2020 15:59:12 +0200 [thread overview]
Message-ID: <20200506155912.478a2ac5.cohuck@redhat.com> (raw)
In-Reply-To: <14c3cf68-c1e5-b46f-d75e-955dbdd63df8@linux.ibm.com>
On Tue, 5 May 2020 09:00:20 -0400
Eric Farman <farman@linux.ibm.com> wrote:
> On 5/5/20 8:56 AM, Cornelia Huck wrote:
> > On Tue, 5 May 2020 14:27:37 +0200
> > Eric Farman <farman@linux.ibm.com> wrote:
> >>
> >>> One thing though that keeps coming up: do we need any kind of
> >>> serialization? Can there be any confusion from concurrent reads from
> >>> userspace, or are we sure that we always provide consistent data?
> >>
> >> I _think_ this is in good shape, though as suggested another set of
> >> eyeballs would be nice. There is still a problem on the main
> >> interrupt/FSM path, which I'm not attempting to address here.
> >
> > I'll try to think about it some more.
I've convinced myself that the patches do not add any new races on top
of what already might be lurking in the existing code.
>
> Re: interrupt/FSM, I now have two separate patches that each straighten
> things out on their own. And a handful of debug patches that probably
> only make things worse. :) I'll get one/both of those meaningful
> patches sent to the list so we can have that discussion separately from
> this code.
Yes, let's do that on top.
I think that the series looks good now, but I'd still like to see
someone else give it a quick look before I queue it.
next prev parent reply other threads:[~2020-05-06 13:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 12:27 [PATCH v4 0/8] s390x/vfio-ccw: Channel Path Handling [KVM] Eric Farman
2020-05-05 12:27 ` [PATCH v4 1/8] vfio-ccw: Introduce new helper functions to free/destroy regions Eric Farman
2020-05-05 12:27 ` [PATCH v4 2/8] vfio-ccw: Register a chp_event callback for vfio-ccw Eric Farman
2020-05-06 13:18 ` Cornelia Huck
2020-05-05 12:27 ` [PATCH v4 3/8] vfio-ccw: Refactor the unregister of the async regions Eric Farman
2020-05-05 12:27 ` [PATCH v4 4/8] vfio-ccw: Introduce a new schib region Eric Farman
2020-05-05 12:27 ` [PATCH v4 5/8] vfio-ccw: Refactor IRQ handlers Eric Farman
2020-05-05 12:27 ` [PATCH v4 6/8] vfio-ccw: Introduce a new CRW region Eric Farman
2020-05-06 13:24 ` Cornelia Huck
2020-05-05 12:27 ` [PATCH v4 7/8] vfio-ccw: Wire up the CRW irq and " Eric Farman
2020-05-06 13:52 ` Cornelia Huck
2020-05-05 12:27 ` [PATCH v4 8/8] vfio-ccw: Add trace for CRW event Eric Farman
2020-05-05 12:56 ` [PATCH v4 0/8] s390x/vfio-ccw: Channel Path Handling [KVM] Cornelia Huck
2020-05-05 13:00 ` Eric Farman
2020-05-06 13:59 ` Cornelia Huck [this message]
2020-05-18 10:05 ` Cornelia Huck
2020-05-18 10:14 ` Eric Farman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506155912.478a2ac5.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=farman@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=jrossi@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox