Re: [PATCH v1 13/17] hmp: Handle virtio-mem when printing memory device info

Pankaj Gupta
2020-05-06T19:04:13Z

> Print the memory device info just like for other memory devices.
>
> Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> monitor/hmp-cmds.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
> index 7f6e982dc8..4b3638a2a6 100644
> --- a/monitor/hmp-cmds.c
> +++ b/monitor/hmp-cmds.c
> @@ -1805,6 +1805,7 @@ void hmp_info_memory_devices(Monitor *mon, const QDict *qdict)
> MemoryDeviceInfoList *info_list = qmp_query_memory_devices(&err);
> MemoryDeviceInfoList *info;
> VirtioPMEMDeviceInfo *vpi;
> + VirtioMEMDeviceInfo *vmi;
> MemoryDeviceInfo *value;
> PCDIMMDeviceInfo *di;
>
> @@ -1839,6 +1840,21 @@ void hmp_info_memory_devices(Monitor *mon, const QDict *qdict)
> monitor_printf(mon, " size: %" PRIu64 "\n", vpi->size);
> monitor_printf(mon, " memdev: %s\n", vpi->memdev);
> break;
> + case MEMORY_DEVICE_INFO_KIND_VIRTIO_MEM:
> + vmi = value->u.virtio_mem.data;
> + monitor_printf(mon, "Memory device [%s]: \"%s\"\n",
> + MemoryDeviceInfoKind_str(value->type),
> + vmi->id ? vmi->id : "");
> + monitor_printf(mon, " memaddr: 0x%" PRIx64 "\n", vmi->memaddr);
> + monitor_printf(mon, " node: %" PRId64 "\n", vmi->node);
> + monitor_printf(mon, " requested-size: %" PRIu64 "\n",
> + vmi->requested_size);
> + monitor_printf(mon, " size: %" PRIu64 "\n", vmi->size);
> + monitor_printf(mon, " max-size: %" PRIu64 "\n", vmi->max_size);
> + monitor_printf(mon, " block-size: %" PRIu64 "\n",
> + vmi->block_size);
> + monitor_printf(mon, " memdev: %s\n", vmi->memdev);
> + break;
> default:
> g_assert_not_reached();
> }
> --
> 2.25.3

Reviewed-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>