Re: [PATCH v1 10/17] virtio-mem: Paravirtualized memory hot(un)plug

David Hildenbrand
2020-05-18T14:23:49Z

>>> +
>>> +static int virtio_mem_pre_save(void *opaque)
>>> +{
>>> + VirtIOMEM *vmem = VIRTIO_MEM(opaque);
>>> +
>>> + vmem->migration_addr = vmem->addr;
>>> + vmem->migration_block_size = vmem->block_size;
>>
>> You might look at VMSTATE_WITH_TMP could avoid you having the dummy
>> fields.
>
> Thanks, will have a look.

VMSTATE_WITH_TMP looks too complicated for this simple use case. I'll
just drop these migration sanity checks for now.

Thanks!

--
Thanks,

David / dhildenb