Re: [PATCH v1 03/17] accel/kvm: Convert to ram_block_discard_set_broken()

Dr. David Alan Gilbert
2020-05-15T11:57:34Z

* David Hildenbrand (david@redhat.com) wrote:
> Discarding memory does not work as expected. At the time this is called,
> we cannot have anyone active that relies on discards to work properly.
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> ---
> accel/kvm/kvm-all.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
> index 439a4efe52..33421184ac 100644
> --- a/accel/kvm/kvm-all.c
> +++ b/accel/kvm/kvm-all.c
> @@ -40,7 +40,6 @@
> #include "trace.h"
> #include "hw/irq.h"
> #include "sysemu/sev.h"
> -#include "sysemu/balloon.h"
> #include "qapi/visitor.h"
> #include "qapi/qapi-types-common.h"
> #include "qapi/qapi-visit-common.h"
> @@ -2107,7 +2106,7 @@ static int kvm_init(MachineState *ms)
>
> s->sync_mmu = !!kvm_vm_check_extension(kvm_state, KVM_CAP_SYNC_MMU);
> if (!s->sync_mmu) {
> - qemu_balloon_inhibit(true);
> + g_assert(ram_block_discard_set_broken(true));
> }
>
> return 0;
> --
> 2.25.3
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK