Re: [PATCH v10 02/14] KVM: Cache as_id in kvm_memory_slot

Peter Xu
2020-07-07T20:15:19Z

On Tue, Jul 07, 2020 at 12:56:58PM -0700, Sean Christopherson wrote:
> > > It's a single line of code, and there's more than one
> > > "shouldn't" in the above.
> >
> > If you want, I can both set it and add the comment. Thanks,
>
> Why bother with the comment? It'd be wrong in the sense that the as_id is
> always valid/accurate, even if npages == 0.

Sorry I'm confused.. when npages==0, why as_id field is meaningful? Even if
the id field is meaningless after the slot is successfully removed, or am I
wrong?

My understanding is that after your dynamic slot work, we'll only have at most
one extra memslot that was just removed, and that slot should be meaningless as
a whole. Feel free to correct me.

--
Peter Xu