From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F2FDC433DF for ; Tue, 2 Jun 2020 13:13:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75EA020810 for ; Tue, 2 Jun 2020 13:13:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="U83LbTLq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726839AbgFBNNd (ORCPT ); Tue, 2 Jun 2020 09:13:33 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:58885 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726728AbgFBNNb (ORCPT ); Tue, 2 Jun 2020 09:13:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591103609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g4VeZ8yHTM87Vh2wY62LbEg+OLfuRTOCLtz4B9KtBSM=; b=U83LbTLqRl1nQuNkWolzrJLm+c+qUcezmwyuAFNzFkzMFYWAIbQ5WezE+EQY6TqxqXfsyg 0MEBvKPwreh0k5a+BRjQcqnDj/PCk2WzcAEQOvUyK+gqOfgUKLnlyJ0/Db1PTpuO69evbP vrNYi2dhN3fA3X2rvMZb2CQ3QfDHnSg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-360-ZiRtPK81MKepDUGaPq_sHw-1; Tue, 02 Jun 2020 09:13:19 -0400 X-MC-Unique: ZiRtPK81MKepDUGaPq_sHw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6160E835B40; Tue, 2 Jun 2020 13:13:18 +0000 (UTC) Received: from gondolin (ovpn-112-184.ams2.redhat.com [10.36.112.184]) by smtp.corp.redhat.com (Postfix) with ESMTP id ABFDD60F8D; Tue, 2 Jun 2020 13:13:16 +0000 (UTC) Date: Tue, 2 Jun 2020 15:13:13 +0200 From: Cornelia Huck To: Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Eric Farman Cc: Halil Pasic , linux-s390@vger.kernel.org, kvm@vger.kernel.org, Farhan Ali Subject: Re: [PULL 08/10] vfio-ccw: Introduce a new CRW region Message-ID: <20200602151313.0e639b57.cohuck@redhat.com> In-Reply-To: <20200525094115.222299-9-cohuck@redhat.com> References: <20200525094115.222299-1-cohuck@redhat.com> <20200525094115.222299-9-cohuck@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, 25 May 2020 11:41:13 +0200 Cornelia Huck wrote: > From: Farhan Ali > > This region provides a mechanism to pass a Channel Report Word > that affect vfio-ccw devices, and needs to be passed to the guest > for its awareness and/or processing. > > The base driver (see crw_collect_info()) provides space for two > CRWs, as a subchannel event may have two CRWs chained together > (one for the ssid, one for the subchannel). As vfio-ccw will > deal with everything at the subchannel level, provide space > for a single CRW to be transferred in one shot. > > Signed-off-by: Farhan Ali > Signed-off-by: Eric Farman > Reviewed-by: Cornelia Huck > Message-Id: <20200505122745.53208-7-farman@linux.ibm.com> > Signed-off-by: Cornelia Huck > --- > Documentation/s390/vfio-ccw.rst | 19 ++++++++++ > drivers/s390/cio/vfio_ccw_chp.c | 55 +++++++++++++++++++++++++++++ > drivers/s390/cio/vfio_ccw_drv.c | 20 +++++++++++ > drivers/s390/cio/vfio_ccw_ops.c | 8 +++++ > drivers/s390/cio/vfio_ccw_private.h | 4 +++ > include/uapi/linux/vfio.h | 2 ++ > include/uapi/linux/vfio_ccw.h | 8 +++++ > 7 files changed, 116 insertions(+) > (...) > @@ -413,6 +423,16 @@ static int __init vfio_ccw_sch_init(void) > goto out_err; > } > > + vfio_ccw_crw_region = kmem_cache_create_usercopy("vfio_ccw_crw_region", > + sizeof(struct ccw_crw_region), 0, > + SLAB_ACCOUNT, 0, > + sizeof(struct ccw_crw_region), NULL); Ugh, I just tested this rebased to the s390 features branch, and I must have used some different options, because I now get kmem_cache_create(vfio_ccw_crw_region) integrity check failed presumably due to the size of the ccw_crw_region. We maybe need to pad it up (leave it unpacked)? Eric, what do you think? > + > + if (!vfio_ccw_crw_region) { > + ret = -ENOMEM; > + goto out_err; > + } > + > isc_register(VFIO_CCW_ISC); > ret = css_driver_register(&vfio_ccw_sch_driver); > if (ret) { (...) > diff --git a/include/uapi/linux/vfio_ccw.h b/include/uapi/linux/vfio_ccw.h > index 758bf214898d..cff5076586df 100644 > --- a/include/uapi/linux/vfio_ccw.h > +++ b/include/uapi/linux/vfio_ccw.h > @@ -44,4 +44,12 @@ struct ccw_schib_region { > __u8 schib_area[SCHIB_AREA_SIZE]; > } __packed; > > +/* > + * Used for returning a Channel Report Word to userspace. > + * Note: this is controlled by a capability > + */ > +struct ccw_crw_region { > + __u32 crw; > +} __packed; > + > #endif