Re: [PATCH v3 00/20] virtio-mem: Paravirtualized memory hot(un)plug

Sean Christopherson
2020-06-09T19:42:06Z

On Tue, Jun 09, 2020 at 02:42:59PM -0400, Michael S. Tsirkin wrote:
> On Tue, Jun 09, 2020 at 08:38:15PM +0200, David Hildenbrand wrote:
> > On 09.06.20 18:18, Eduardo Habkost wrote:
> > > On Tue, Jun 09, 2020 at 11:59:04AM -0400, Michael S. Tsirkin wrote:
> > >> On Tue, Jun 09, 2020 at 03:26:08PM +0200, David Hildenbrand wrote:
> > >>> On 09.06.20 15:11, Michael S. Tsirkin wrote:
> > >>>> On Wed, Jun 03, 2020 at 04:48:54PM +0200, David Hildenbrand wrote:
> > >>>>> This is the very basic, initial version of virtio-mem. More info on
> > >>>>> virtio-mem in general can be found in the Linux kernel driver v2 posting
> > >>>>> [1] and in patch #10. The latest Linux driver v4 can be found at [2].
> > >>>>>
> > >>>>> This series is based on [3]:
> > >>>>> "[PATCH v1] pc: Support coldplugging of virtio-pmem-pci devices on all
> > >>>>> buses"
> > >>>>>
> > >>>>> The patches can be found at:
> > >>>>> https://github.com/davidhildenbrand/qemu.git virtio-mem-v3
> > >>>>
> > >>>> So given we tweaked the config space a bit, this needs a respin.
> > >>>
> > >>> Yeah, the virtio-mem-v4 branch already contains a fixed-up version. Will
> > >>> send during the next days.
> > >>
> > >> BTW. People don't normally capitalize the letter after ":".
> > >> So a better subject is
> > >> virtio-mem: paravirtualized memory hot(un)plug
> > >
> > > I'm not sure that's still the rule:
> > >
> > > [qemu/(49ee115552...)]$ git log --oneline v4.0.0.. | egrep ': [A-Z]' | wc -l
> > > 5261
> > > [qemu/(49ee115552...)]$ git log --oneline v4.0.0.. | egrep ': [a-z]' | wc -l
> > > 2921
> > >
> >
> > Yeah, I switched to this scheme some years ago (I even remember that
> > some QEMU maintainer recommended it). I decided to just always
> > capitalize. Not that it should really matter ... :)
>
> Don't mind about qemu but you don't want to do that for Linux.

Heh, depends on who you ask. The tip tree maintainers (strongly) prefer
capitalizing the first word after the colon[*], and that naturally
percolates into a lot of other subsystems, e.g. I follow that pattern for
KVM so that I don't have to remember to switch when submitting patches
against a tip branch.

+Patch subject
+^^^^^^^^^^^^^
+
+The tip tree preferred format for patch subject prefixes is
+'subsys/component:', e.g. 'x86/apic:', 'x86/mm/fault:', 'sched/fair:',
+'genirq/core:'. Please do not use file names or complete file paths as
+prefix. 'git log path/to/file' should give you a reasonable hint in most
+cases.
+
+The condensed patch description in the subject line should start with a
+uppercase letter and should be written in imperative tone.

[*] https://lkml.kernel.org/r/20181107171149.165693799@linutronix.de