From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9C41C433DF for ; Thu, 4 Jun 2020 11:27:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96AE4206E6 for ; Thu, 4 Jun 2020 11:27:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CtDmCnfu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726228AbgFDL1b (ORCPT ); Thu, 4 Jun 2020 07:27:31 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:46715 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725601AbgFDL1b (ORCPT ); Thu, 4 Jun 2020 07:27:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591270050; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rp4fAo1ax4WZsSXkT7tUPY6cOf761WqUjP3FSXYOQp8=; b=CtDmCnfuoU5sYu+dRgz5BZO2uS0vfcqyC6IScj5xR979Oq7N5LjEmYlieBjF1z66rjOhD4 eDK3SUugq/DYc5fHyvl7vltrvgG2EEHNWem62PpxvxofH6RWMNmFhWCpcdZUZCSiEgtSRQ ubvN0HO2conMmQph5Pw7kd/ecdGIAq4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-290-K-rcBVYNORuwCiiSxB1cOQ-1; Thu, 04 Jun 2020 07:27:26 -0400 X-MC-Unique: K-rcBVYNORuwCiiSxB1cOQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 511A0835B42; Thu, 4 Jun 2020 11:27:25 +0000 (UTC) Received: from gondolin (ovpn-112-76.ams2.redhat.com [10.36.112.76]) by smtp.corp.redhat.com (Postfix) with ESMTP id C6E9C5C28E; Thu, 4 Jun 2020 11:27:23 +0000 (UTC) Date: Thu, 4 Jun 2020 13:27:21 +0200 From: Cornelia Huck To: Vasily Gorbik Cc: Heiko Carstens , Christian Borntraeger , Eric Farman , Halil Pasic , linux-s390@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH] vfio-ccw: make vfio_ccw_regops variables declarations static Message-ID: <20200604132721.63b11800.cohuck@redhat.com> In-Reply-To: References: <20200603112716.332801-1-cohuck@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, 4 Jun 2020 13:20:45 +0200 Vasily Gorbik wrote: > Fixes the following sparse warnings: > drivers/s390/cio/vfio_ccw_chp.c:62:30: warning: symbol 'vfio_ccw_schib_region_ops' was not declared. Should it be static? > drivers/s390/cio/vfio_ccw_chp.c:117:30: warning: symbol 'vfio_ccw_crw_region_ops' was not declared. Should it be static? > > Signed-off-by: Vasily Gorbik > --- > drivers/s390/cio/vfio_ccw_chp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/s390/cio/vfio_ccw_chp.c b/drivers/s390/cio/vfio_ccw_chp.c > index 876f6ade51cc..a646fc81c872 100644 > --- a/drivers/s390/cio/vfio_ccw_chp.c > +++ b/drivers/s390/cio/vfio_ccw_chp.c > @@ -59,7 +59,7 @@ static void vfio_ccw_schib_region_release(struct vfio_ccw_private *private, > > } > > -const struct vfio_ccw_regops vfio_ccw_schib_region_ops = { > +static const struct vfio_ccw_regops vfio_ccw_schib_region_ops = { > .read = vfio_ccw_schib_region_read, > .write = vfio_ccw_schib_region_write, > .release = vfio_ccw_schib_region_release, > @@ -131,7 +131,7 @@ static void vfio_ccw_crw_region_release(struct vfio_ccw_private *private, > > } > > -const struct vfio_ccw_regops vfio_ccw_crw_region_ops = { > +static const struct vfio_ccw_regops vfio_ccw_crw_region_ops = { > .read = vfio_ccw_crw_region_read, > .write = vfio_ccw_crw_region_write, > .release = vfio_ccw_crw_region_release, Oops. Reviewed-by: Cornelia Huck Feel free to merge this directly.