From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E75CCC433E0 for ; Fri, 5 Jun 2020 12:48:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C159C2065C for ; Fri, 5 Jun 2020 12:48:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HoHfI3/t" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726894AbgFEMsX (ORCPT ); Fri, 5 Jun 2020 08:48:23 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:50515 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726552AbgFEMsX (ORCPT ); Fri, 5 Jun 2020 08:48:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591361301; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eO1D3JEFx3gMyiYe03xD1d+mWzCgrlVM6JLDMuUPpwI=; b=HoHfI3/tB7+HeilpL1Jd+0KsMn5HCNh2ckp81PWMODwkEngcXQh5iuAmKiLQBfhhjZpVAE 3hHfCYLfMbVeOMIlEvohEOKD8nolBvu2uQfYFZU+gXCRzo66IqIvKbIpDI8fL9WIvD5A9D AkuDjvQGANB4DjxzobJOhYCDzHjGjXg= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-463-yhxzd053PNWFy3AoTY_cjQ-1; Fri, 05 Jun 2020 08:48:20 -0400 X-MC-Unique: yhxzd053PNWFy3AoTY_cjQ-1 Received: by mail-qt1-f200.google.com with SMTP id p31so8368046qte.1 for ; Fri, 05 Jun 2020 05:48:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eO1D3JEFx3gMyiYe03xD1d+mWzCgrlVM6JLDMuUPpwI=; b=T3bbA3Sf1piXSijy/bV0W/LnGzICvvD0q71U3I4g5jBIrtIU54Em2SGZ3nZsq9rEOO jObIftykEdGx+uzHrz23vZ7+sgCRRZF0ax+hNI+LvwAsv2UaVC9Q47C5ETkMi3Lgp6Gd 5h+7k32XqKgC0W89AqCacBUF3LuGWL12i9/7zHWE9otSck3i6geckC9hqseJXt7G7BQq XWQS938boFh2ka5gwbdLn3Ajwl+LgFlEtke6rNiQZLZPBBlxem43RHfImlQqGbDdjCWe hsN2nWSXtCn2ZTEedKEl2mJW8DilAiw60wiZK4wBhazg8j0KWqhtdvzvdBTSEaSkfnEz h8DQ== X-Gm-Message-State: AOAM533dnfTkFG2KmMlMUvFqIwuQELpjiHqySLLin6ZqDT1lK7g+izwJ kManx8IMiPHVYsemlC5Y0KcH8eX+p9nLiUUYdR1zGtwAuTD26rGNEaaNxhJtTIz+FUHc6LupRYj EKqIQsBWR4dav X-Received: by 2002:aed:21af:: with SMTP id l44mr10019746qtc.124.1591361299525; Fri, 05 Jun 2020 05:48:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwKVSPnObIIx/lF3VrXTnCi0p2UjVU2aEXiipGyR5R5g+TcrRTsbvtNz/PEa3g8UQfd15ZLLQ== X-Received: by 2002:aed:21af:: with SMTP id l44mr10019726qtc.124.1591361299260; Fri, 05 Jun 2020 05:48:19 -0700 (PDT) Received: from xz-x1 ([2607:9880:19c0:32::2]) by smtp.gmail.com with ESMTPSA id j5sm7534542qtr.73.2020.06.05.05.48.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2020 05:48:18 -0700 (PDT) Date: Fri, 5 Jun 2020 08:48:16 -0400 From: Peter Xu To: Andrew Jones Cc: Paolo Bonzini , Dan Carpenter , Ben Gardon , Shuah Khan , kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] KVM: selftests: delete some dead code Message-ID: <20200605124816.GB55548@xz-x1> References: <20200605110048.GB978434@mwanda> <9f20e25d-599d-c203-e3d4-905b122ef5a3@redhat.com> <20200605115316.z5tavmf5rjobypve@kamzik.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200605115316.z5tavmf5rjobypve@kamzik.brq.redhat.com> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Jun 05, 2020 at 01:53:16PM +0200, Andrew Jones wrote: > On Fri, Jun 05, 2020 at 01:16:59PM +0200, Paolo Bonzini wrote: > > On 05/06/20 13:00, Dan Carpenter wrote: > > > The "uffd_delay" variable is unsigned so it's always going to be >= 0. > > > > > > Fixes: 0119cb365c93 ("KVM: selftests: Add configurable demand paging delay") > > > Signed-off-by: Dan Carpenter > > > --- > > > tools/testing/selftests/kvm/demand_paging_test.c | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/tools/testing/selftests/kvm/demand_paging_test.c b/tools/testing/selftests/kvm/demand_paging_test.c > > > index 360cd3ea4cd67..4eb79621434e6 100644 > > > --- a/tools/testing/selftests/kvm/demand_paging_test.c > > > +++ b/tools/testing/selftests/kvm/demand_paging_test.c > > > @@ -615,8 +615,6 @@ int main(int argc, char *argv[]) > > > break; > > > case 'd': > > > uffd_delay = strtoul(optarg, NULL, 0); > > > - TEST_ASSERT(uffd_delay >= 0, > > > - "A negative UFFD delay is not supported."); > > > break; > > > case 'b': > > > vcpu_memory_bytes = parse_size(optarg); > > > > > > > The bug is that strtoul is "impossible" to use correctly. Could I ask why? > > The right fix > > would be to have a replacement for strtoul. > > The test needs an upper limit. It obviously doesn't make sense to ever > want a ULONG_MAX usec delay. What's the maximum number of usecs we should > allow? Maybe this test can also be used to emulate a hang-forever kvm mmu fault due to some reason we wanted, by specifying an extremely large value here? From that POV, seems still ok to even keep it unbound as a test... Thanks, -- Peter Xu