Re: [PATCH 18/21] KVM: arm64: Use common KVM implementation of MMU memory caches

Sean Christopherson
2020-06-11T15:46:20Z

On Thu, Jun 11, 2020 at 09:01:44AM +0100, Marc Zyngier wrote:
> On 2020-06-05 22:38, Sean Christopherson wrote:

...

> >@@ -1024,7 +993,7 @@ static pud_t *stage2_get_pud(struct kvm *kvm,
> >struct kvm_mmu_memory_cache *cache
> > if (stage2_pgd_none(kvm, *pgd)) {
> > if (!cache)
> > return NULL;
> >- pud = mmu_memory_cache_alloc(cache);
> >+ pud = kvm_mmu_memory_cache_alloc(cache);
> > stage2_pgd_populate(kvm, pgd, pud);
> > get_page(virt_to_page(pgd));
> > }
>
> Quick note: this patch (as it is) breaks on arm64 due to Mike Rapoport's
> P4D rework. I've fixed it locally in order to test the series.

Good to know, I'll wait to send v2 until that gets pulled into Paolo's tree.
Thanks for the heads up, and especially for testing!