From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88547C433DF for ; Tue, 16 Jun 2020 11:17:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5048D2098B for ; Tue, 16 Jun 2020 11:17:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PFKVwNpr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726799AbgFPLRy (ORCPT ); Tue, 16 Jun 2020 07:17:54 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:49416 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725768AbgFPLRv (ORCPT ); Tue, 16 Jun 2020 07:17:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592306269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=da8UnOZcqvP4RkUxtdOC7xKwlzyHgAbrTXZEHOn7keo=; b=PFKVwNprn6rYCTwGuRpGSlaU1bnMppJJ9AOoRMchQ3FZXZ8ON4DZkCGr8ZFLa+YgdD//rB 9oVktuhRA1jHFTemkdXCXWC5mgewPjHBndhYz+IR3FNKwKiUyWAchCU8ppE25+H2hEzoIk +C3o1iHL3+06OXC1lFGQ50r01Kw0GoE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-370-S5uGZ7BrODihBcFKB5hMLQ-1; Tue, 16 Jun 2020 07:17:44 -0400 X-MC-Unique: S5uGZ7BrODihBcFKB5hMLQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 10A2F100945A; Tue, 16 Jun 2020 11:17:43 +0000 (UTC) Received: from gondolin (ovpn-112-222.ams2.redhat.com [10.36.112.222]) by smtp.corp.redhat.com (Postfix) with ESMTP id DAAE46FDD1; Tue, 16 Jun 2020 11:17:35 +0000 (UTC) Date: Tue, 16 Jun 2020 13:17:32 +0200 From: Cornelia Huck To: David Hildenbrand Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, qemu-s390x@nongnu.org, Richard Henderson , Paolo Bonzini , "Dr . David Alan Gilbert" , Eduardo Habkost , "Michael S . Tsirkin" , Halil Pasic , Christian Borntraeger , Janosch Frank Subject: Re: [PATCH v4 04/21] s390x/pv: Convert to ram_block_discard_disable() Message-ID: <20200616131732.52eb76d1.cohuck@redhat.com> In-Reply-To: <20200610115419.51688-5-david@redhat.com> References: <20200610115419.51688-1-david@redhat.com> <20200610115419.51688-5-david@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, 10 Jun 2020 13:54:02 +0200 David Hildenbrand wrote: > Discarding RAM does not work as expected with protected VMs. Let's > switch to ram_block_discard_disable() for now, as we want to get rid > of qemu_balloon_inhibit(). Note that it will currently never fail, but > might fail in the future with new technologies (e.g., virtio-mem). > > Cc: Richard Henderson > Cc: Cornelia Huck > Cc: Halil Pasic > Cc: Christian Borntraeger > Cc: Janosch Frank > Signed-off-by: David Hildenbrand > --- > hw/s390x/s390-virtio-ccw.c | 22 +++++++++++++--------- > 1 file changed, 13 insertions(+), 9 deletions(-) Did not review in detail, but looks sane. Would like to see a sanity check and ack from folks with access to a PV setup. Acked-by: Cornelia Huck