From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C4E7C433DF for ; Tue, 16 Jun 2020 12:21:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 635D520C09 for ; Tue, 16 Jun 2020 12:21:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gyr9sNwb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728743AbgFPMV2 (ORCPT ); Tue, 16 Jun 2020 08:21:28 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:33890 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728694AbgFPMV0 (ORCPT ); Tue, 16 Jun 2020 08:21:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592310085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h2SlXHGpqwt43th89psSAGozPMwGRRAsdb7ODXzU9w0=; b=gyr9sNwbPl+nXW49OIQ9ZaYti1hISkEEpiGS35C3Kd03CU/GVu2vS3sMzjXl2290fBfWAO i27GlZTqnVOzc5TCjmnaASC0Z8fvrBu1hM8mY9qVHhARjyCUMgIvEDlb+TD52Xu1EfuBwa PH3tBonHXZG0vg2jcRyXopyBpuF+rGU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-98-FYI6Xt7gPKyDGTLzv_M7uQ-1; Tue, 16 Jun 2020 08:21:21 -0400 X-MC-Unique: FYI6Xt7gPKyDGTLzv_M7uQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CBB4B8005AD; Tue, 16 Jun 2020 12:21:19 +0000 (UTC) Received: from gondolin (ovpn-112-222.ams2.redhat.com [10.36.112.222]) by smtp.corp.redhat.com (Postfix) with ESMTP id D5AE31001B2B; Tue, 16 Jun 2020 12:21:14 +0000 (UTC) Date: Tue, 16 Jun 2020 14:21:12 +0200 From: Cornelia Huck To: Pierre Morel Cc: Christian Borntraeger , linux-kernel@vger.kernel.org, pasic@linux.ibm.com, frankja@linux.ibm.com, mst@redhat.com, jasowang@redhat.com, kvm@vger.kernel.org, linux-s390@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v2 1/1] s390: virtio: let arch accept devices without IOMMU feature Message-ID: <20200616142112.2d08ff7d.cohuck@redhat.com> In-Reply-To: References: <1592224764-1258-1-git-send-email-pmorel@linux.ibm.com> <1592224764-1258-2-git-send-email-pmorel@linux.ibm.com> <74b6cf8a-d5a6-e0bf-f1c1-e453af133614@de.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, 16 Jun 2020 09:35:19 +0200 Pierre Morel wrote: > On 2020-06-16 08:55, Christian Borntraeger wrote: > > > > > > On 15.06.20 14:39, Pierre Morel wrote: > >> An architecture protecting the guest memory against unauthorized host > >> access may want to enforce VIRTIO I/O device protection through the > >> use of VIRTIO_F_IOMMU_PLATFORM. > >> > >> Let's give a chance to the architecture to accept or not devices > >> without VIRTIO_F_IOMMU_PLATFORM. > >> > >> Signed-off-by: Pierre Morel > > > > > > Acked-by: Christian Borntraeger > > Thanks, > > > > > Shouldnt we maybe add a pr_warn if that happens to help the admins to understand what is going on? > > > > > > Yes, Connie asked for it too, good that you remind it to me, I add it. Yes, please :)