From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B73B4C433E2 for ; Thu, 18 Jun 2020 01:55:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 983D62224A for ; Thu, 18 Jun 2020 01:55:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SpxSV7CM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731514AbgFRBZt (ORCPT ); Wed, 17 Jun 2020 21:25:49 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:50390 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731493AbgFRBZq (ORCPT ); Wed, 17 Jun 2020 21:25:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592443545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y7xJe4wll8RNT7ZvRCMxIEw6+h6IlLNJEj6S4QZiEyg=; b=SpxSV7CMA3WO2JYsDZ7iECyZo6yrsYFV3QQyQ43EbsWFyrwOXd2aYo5X9TDg5LzuD9rrWw KDYq3JhKPjYzUx1NNPrwQHNNydfmxh27J4ORcahbPPHXoQaXy+CDbYiOq25qI6mmW7vKIL TC2Bj0oHKnlO6UxExgN4w5QHoH6oID0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-177-VWZLx5xVO2-22TnHDUQr5w-1; Wed, 17 Jun 2020 21:25:43 -0400 X-MC-Unique: VWZLx5xVO2-22TnHDUQr5w-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C83A58018A6; Thu, 18 Jun 2020 01:25:41 +0000 (UTC) Received: from x1.home (ovpn-112-195.phx2.redhat.com [10.3.112.195]) by smtp.corp.redhat.com (Postfix) with ESMTP id 67DEA7CAC4; Thu, 18 Jun 2020 01:25:41 +0000 (UTC) Date: Wed, 17 Jun 2020 19:25:40 -0600 From: Alex Williamson To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Qian Cai , kvm@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.4 191/266] vfio/pci: fix memory leaks of eventfd ctx Message-ID: <20200617192540.7da361fd@x1.home> In-Reply-To: <20200618011631.604574-191-sashal@kernel.org> References: <20200618011631.604574-1-sashal@kernel.org> <20200618011631.604574-191-sashal@kernel.org> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, 17 Jun 2020 21:15:16 -0400 Sasha Levin wrote: > From: Qian Cai > > [ Upstream commit 1518ac272e789cae8c555d69951b032a275b7602 ] > > Finished a qemu-kvm (-device vfio-pci,host=0001:01:00.0) triggers a few > memory leaks after a while because vfio_pci_set_ctx_trigger_single() > calls eventfd_ctx_fdget() without the matching eventfd_ctx_put() later. > Fix it by calling eventfd_ctx_put() for those memory in > vfio_pci_release() before vfio_device_release(). > > unreferenced object 0xebff008981cc2b00 (size 128): > comm "qemu-kvm", pid 4043, jiffies 4294994816 (age 9796.310s) > hex dump (first 32 bytes): > 01 00 00 00 6b 6b 6b 6b 00 00 00 00 ad 4e ad de ....kkkk.....N.. > ff ff ff ff 6b 6b 6b 6b ff ff ff ff ff ff ff ff ....kkkk........ > backtrace: > [<00000000917e8f8d>] slab_post_alloc_hook+0x74/0x9c > [<00000000df0f2aa2>] kmem_cache_alloc_trace+0x2b4/0x3d4 > [<000000005fcec025>] do_eventfd+0x54/0x1ac > [<0000000082791a69>] __arm64_sys_eventfd2+0x34/0x44 > [<00000000b819758c>] do_el0_svc+0x128/0x1dc > [<00000000b244e810>] el0_sync_handler+0xd0/0x268 > [<00000000d495ef94>] el0_sync+0x164/0x180 > unreferenced object 0x29ff008981cc4180 (size 128): > comm "qemu-kvm", pid 4043, jiffies 4294994818 (age 9796.290s) > hex dump (first 32 bytes): > 01 00 00 00 6b 6b 6b 6b 00 00 00 00 ad 4e ad de ....kkkk.....N.. > ff ff ff ff 6b 6b 6b 6b ff ff ff ff ff ff ff ff ....kkkk........ > backtrace: > [<00000000917e8f8d>] slab_post_alloc_hook+0x74/0x9c > [<00000000df0f2aa2>] kmem_cache_alloc_trace+0x2b4/0x3d4 > [<000000005fcec025>] do_eventfd+0x54/0x1ac > [<0000000082791a69>] __arm64_sys_eventfd2+0x34/0x44 > [<00000000b819758c>] do_el0_svc+0x128/0x1dc > [<00000000b244e810>] el0_sync_handler+0xd0/0x268 > [<00000000d495ef94>] el0_sync+0x164/0x180 > > Signed-off-by: Qian Cai > Signed-off-by: Alex Williamson > Signed-off-by: Sasha Levin > --- > drivers/vfio/pci/vfio_pci.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c > index 02206162eaa9..d917dd2df3b3 100644 > --- a/drivers/vfio/pci/vfio_pci.c > +++ b/drivers/vfio/pci/vfio_pci.c > @@ -472,6 +472,10 @@ static void vfio_pci_release(void *device_data) > if (!(--vdev->refcnt)) { > vfio_spapr_pci_eeh_release(vdev->pdev); > vfio_pci_disable(vdev); > + if (vdev->err_trigger) > + eventfd_ctx_put(vdev->err_trigger); > + if (vdev->req_trigger) > + eventfd_ctx_put(vdev->req_trigger); > } > > mutex_unlock(&vdev->reflck->lock); This has a fix pending, I'd suggest not picking it on its own: https://lore.kernel.org/kvm/20200616085052.sahrunsesjyjeyf2@beryllium.lan/ https://lore.kernel.org/kvm/159234276956.31057.6902954364435481688.stgit@gimli.home/ Thanks, Alex