From: Cornelia Huck <cohuck@redhat.com>
To: Pierre Morel <pmorel@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
frankja@linux.ibm.com, david@redhat.com, thuth@redhat.com
Subject: Re: [kvm-unit-tests PATCH v9 12/12] s390x: css: ssch/tsch with sense and interrupt
Date: Fri, 19 Jun 2020 08:57:18 +0200 [thread overview]
Message-ID: <20200619085718.25964a0a.cohuck@redhat.com> (raw)
In-Reply-To: <2383bdc0-caaf-9cb0-f4c4-ed57c1d3dfb1@linux.ibm.com>
On Wed, 17 Jun 2020 13:55:52 +0200
Pierre Morel <pmorel@linux.ibm.com> wrote:
> On 2020-06-17 11:54, Cornelia Huck wrote:
> > On Mon, 15 Jun 2020 11:32:01 +0200
> > Pierre Morel <pmorel@linux.ibm.com> wrote:
(...)
> >> +int start_subchannel(unsigned int sid, int code, void *data, int count,
> >> + unsigned char flags)
> >> +{
> >> + int cc;
> >> + struct ccw1 *ccw = &unique_ccw;
> >
> > Hm... it might better to call this function "start_single_ccw" or
> > something like that.
>
> You are right.
> I will rework this.
> What about differentiating this badly named "start_subchannel()" into:
>
> ccw_setup_ccw(ccw, data, cnt, flgs);
> ccw_setup_orb(orb, ccw, flgs)
> ccw_start_request(schid, orb);
>
> would be much clearer I think.
Not sure about ccw_setup_ccw; might get a bit non-obvious if you're
trying to build a chain.
Let's see how this turns out.
(...)
> I will rework this.
>
> - rework the start_subchannel()
> - rework the read_len() if we ever need this
I think checking the count after the request concluded is actually a
good idea. In the future, we could also add a check that it matches the
requested length for a request where SLI was not specified.
>
> Also thinking to put the irq_io routine inside the library, it will be
> reused by other tests.
Yes, that probably makes sense as well.
next prev parent reply other threads:[~2020-06-19 6:57 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 9:31 [kvm-unit-tests PATCH v9 00/12] s390x: Testing the Channel Subsystem I/O Pierre Morel
2020-06-15 9:31 ` [kvm-unit-tests PATCH v9 01/12] s390x: Use PSW bits definitions in cstart Pierre Morel
2020-06-16 9:31 ` Thomas Huth
2020-06-16 9:39 ` Pierre Morel
2020-06-16 13:13 ` Thomas Huth
2020-06-16 13:58 ` Pierre Morel
2020-06-16 14:01 ` Pierre Morel
2020-06-16 15:14 ` Thomas Huth
2020-06-16 16:08 ` Pierre Morel
2020-06-16 16:11 ` Pierre Morel
2020-06-15 9:31 ` [kvm-unit-tests PATCH v9 02/12] s390x: Move control register bit definitions and add AFP to them Pierre Morel
2020-06-15 9:31 ` [kvm-unit-tests PATCH v9 03/12] s390x: saving regs for interrupts Pierre Morel
2020-06-17 8:13 ` Cornelia Huck
2020-06-15 9:31 ` [kvm-unit-tests PATCH v9 04/12] s390x: interrupt registration Pierre Morel
2020-06-17 8:20 ` Cornelia Huck
2020-06-17 11:01 ` Pierre Morel
2020-06-15 9:31 ` [kvm-unit-tests PATCH v9 05/12] s390x: export the clock get_clock_ms() utility Pierre Morel
2020-06-15 9:31 ` [kvm-unit-tests PATCH v9 06/12] s390x: clock and delays caluculations Pierre Morel
2020-06-16 9:35 ` Thomas Huth
2020-06-16 9:40 ` Pierre Morel
2020-06-17 8:27 ` Cornelia Huck
2020-06-17 11:04 ` Pierre Morel
2020-06-22 9:09 ` Janosch Frank
2020-06-30 16:13 ` Pierre Morel
2020-06-15 9:31 ` [kvm-unit-tests PATCH v9 07/12] s390x: define function to wait for interrupt Pierre Morel
2020-06-15 9:31 ` [kvm-unit-tests PATCH v9 08/12] s390x: retrieve decimal and hexadecimal kernel parameters Pierre Morel
2020-06-16 9:47 ` Thomas Huth
2020-06-16 13:43 ` Pierre Morel
2020-06-17 8:37 ` Cornelia Huck
2020-06-17 11:05 ` Pierre Morel
2020-06-22 9:33 ` Janosch Frank
2020-06-22 10:57 ` Andrew Jones
2020-07-02 12:53 ` Pierre Morel
2020-06-15 9:31 ` [kvm-unit-tests PATCH v9 09/12] s390x: Library resources for CSS tests Pierre Morel
2020-06-16 10:31 ` Thomas Huth
2020-06-16 13:42 ` Pierre Morel
2020-06-17 8:42 ` Cornelia Huck
2020-06-17 11:08 ` Pierre Morel
2020-06-22 9:35 ` Janosch Frank
2020-06-24 12:26 ` Thomas Huth
2020-06-30 16:30 ` Pierre Morel
2020-06-15 9:31 ` [kvm-unit-tests PATCH v9 10/12] s390x: css: stsch, enumeration test Pierre Morel
2020-06-16 11:37 ` Thomas Huth
2020-06-16 13:42 ` Pierre Morel
2020-06-17 8:48 ` Cornelia Huck
2020-06-17 11:14 ` Pierre Morel
2020-06-15 9:32 ` [kvm-unit-tests PATCH v9 11/12] s390x: css: msch, enable test Pierre Morel
2020-06-16 11:43 ` Thomas Huth
2020-06-16 13:43 ` Pierre Morel
2020-06-17 8:54 ` Cornelia Huck
2020-06-17 11:25 ` Pierre Morel
2020-06-15 9:32 ` [kvm-unit-tests PATCH v9 12/12] s390x: css: ssch/tsch with sense and interrupt Pierre Morel
2020-06-17 9:54 ` Cornelia Huck
2020-06-17 11:55 ` Pierre Morel
2020-06-19 6:57 ` Cornelia Huck [this message]
2020-07-02 12:56 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619085718.25964a0a.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pmorel@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox