From: Nadav Amit <namit@vmware.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: <kvm@vger.kernel.org>, Nadav Amit <namit@vmware.com>
Subject: [PATCH] x86: fix smp_stacktop on 32-bit
Date: Wed, 24 Jun 2020 13:36:02 -0700 [thread overview]
Message-ID: <20200624203602.44659-1-namit@vmware.com> (raw)
smp_stacktop in 32-bit is fixed to some magic address. Use the address
of the memory that was reserved for the stack instead.
Signed-off-by: Nadav Amit <namit@vmware.com>
---
x86/cstart.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/x86/cstart.S b/x86/cstart.S
index 1d8b8ac..a072aed 100644
--- a/x86/cstart.S
+++ b/x86/cstart.S
@@ -134,7 +134,7 @@ prepare_32:
mov %eax, %cr0
ret
-smp_stacktop: .long 0xa0000
+smp_stacktop: .long stacktop - 4096
save_id:
movl $(APIC_DEFAULT_PHYS_BASE + APIC_ID), %eax
--
2.20.1
next reply other threads:[~2020-06-24 20:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 20:36 Nadav Amit [this message]
2020-06-25 10:41 ` [PATCH] x86: fix smp_stacktop on 32-bit Paolo Bonzini
2020-06-25 11:15 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624203602.44659-1-namit@vmware.com \
--to=namit@vmware.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox