From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: kvm@vger.kernel.org, pbonzini@redhat.com
Cc: frankja@linux.ibm.com, thuth@redhat.com, david@redhat.com
Subject: [kvm-unit-tests PATCH v1 2/4] lib/alloc_page: change some parameter types
Date: Fri, 3 Jul 2020 13:51:07 +0200 [thread overview]
Message-ID: <20200703115109.39139-3-imbrenda@linux.ibm.com> (raw)
In-Reply-To: <20200703115109.39139-1-imbrenda@linux.ibm.com>
For size parameters, size_t is probably semantically more appropriate
than unsigned long (although they map to the same value).
For order, unsigned long is just too big. Also, get_order returns an
unsigned int anyway.
Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
---
lib/alloc_page.h | 6 +++---
lib/alloc_page.c | 8 ++++----
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/lib/alloc_page.h b/lib/alloc_page.h
index 6181299..d9aceb7 100644
--- a/lib/alloc_page.h
+++ b/lib/alloc_page.h
@@ -11,10 +11,10 @@
bool page_alloc_initialized(void);
void page_alloc_ops_enable(void);
void *alloc_page(void);
-void *alloc_pages(unsigned long order);
+void *alloc_pages(unsigned int order);
void free_page(void *page);
-void free_pages(void *mem, unsigned long size);
-void free_pages_by_order(void *mem, unsigned long order);
+void free_pages(void *mem, size_t size);
+void free_pages_by_order(void *mem, unsigned int order);
unsigned int get_order(size_t size);
#endif
diff --git a/lib/alloc_page.c b/lib/alloc_page.c
index 8769c3f..f16eaad 100644
--- a/lib/alloc_page.c
+++ b/lib/alloc_page.c
@@ -21,7 +21,7 @@ bool page_alloc_initialized(void)
return freelist != 0;
}
-void free_pages(void *mem, unsigned long size)
+void free_pages(void *mem, size_t size)
{
void *old_freelist;
void *end;
@@ -53,7 +53,7 @@ void free_pages(void *mem, unsigned long size)
spin_unlock(&lock);
}
-void free_pages_by_order(void *mem, unsigned long order)
+void free_pages_by_order(void *mem, unsigned int order)
{
free_pages(mem, 1ul << (order + PAGE_SHIFT));
}
@@ -79,7 +79,7 @@ void *alloc_page()
* Allocates (1 << order) physically contiguous and naturally aligned pages.
* Returns NULL if there's no memory left.
*/
-void *alloc_pages(unsigned long order)
+void *alloc_pages(unsigned int order)
{
/* Generic list traversal. */
void *prev;
@@ -150,7 +150,7 @@ void free_page(void *page)
static void *page_memalign(size_t alignment, size_t size)
{
unsigned long n = ALIGN(size, PAGE_SIZE) >> PAGE_SHIFT;
- unsigned long order;
+ unsigned int order;
if (!size)
return NULL;
--
2.26.2
next prev parent reply other threads:[~2020-07-03 11:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 11:51 [kvm-unit-tests PATCH v1 0/4] More lib/alloc cleanup and a minor improvement Claudio Imbrenda
2020-07-03 11:51 ` [kvm-unit-tests PATCH v1 1/4] lib/vmalloc: fix pages count local variable to be size_t Claudio Imbrenda
2020-07-03 11:51 ` Claudio Imbrenda [this message]
2020-07-03 11:51 ` [kvm-unit-tests PATCH v1 3/4] lib/alloc_page: move get_order and is_power_of_2 to a bitops.h Claudio Imbrenda
2020-07-03 11:51 ` [kvm-unit-tests PATCH v1 4/4] lib/vmalloc: allow vm_memalign with alignment > PAGE_SIZE Claudio Imbrenda
2020-07-03 12:30 ` Andrew Jones
2020-07-03 13:49 ` Claudio Imbrenda
2020-07-03 16:20 ` Paolo Bonzini
2020-07-03 12:30 ` [kvm-unit-tests PATCH v1 0/4] More lib/alloc cleanup and a minor improvement Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200703115109.39139-3-imbrenda@linux.ibm.com \
--to=imbrenda@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox