From: Peter Xu <peterx@redhat.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Andrew Jones <drjones@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH v10 02/14] KVM: Cache as_id in kvm_memory_slot
Date: Tue, 7 Jul 2020 16:38:23 -0400 [thread overview]
Message-ID: <20200707203823.GI88106@xz-x1> (raw)
In-Reply-To: <20200707202623.GM20096@linux.intel.com>
On Tue, Jul 07, 2020 at 01:26:23PM -0700, Sean Christopherson wrote:
> On Tue, Jul 07, 2020 at 04:15:08PM -0400, Peter Xu wrote:
> > On Tue, Jul 07, 2020 at 12:56:58PM -0700, Sean Christopherson wrote:
> > > > > It's a single line of code, and there's more than one
> > > > > "shouldn't" in the above.
> > > >
> > > > If you want, I can both set it and add the comment. Thanks,
> > >
> > > Why bother with the comment? It'd be wrong in the sense that the as_id is
> > > always valid/accurate, even if npages == 0.
> >
> > Sorry I'm confused.. when npages==0, why as_id field is meaningful? Even if
> > the id field is meaningless after the slot is successfully removed, or am I
> > wrong?
> >
> > My understanding is that after your dynamic slot work, we'll only have at most
> > one extra memslot that was just removed, and that slot should be meaningless as
> > a whole. Feel free to correct me.
>
> Your understanding is correct. What I'm saying is that if something goes
> awry and the memslots need to be debugged, having accurate info for that one
> defunct memslot could be helpful, if only to not confuse a future debugger
> that doesn't fully understand memslots or address spaces. Sure, it could be
> manually added back in for debug, but it's literally a single line of code
> to carry and it avoids the need for a special comment.
Sure, will do. But again, I hope you allow me to add at least some comment.
To me, it's still weird to set these in a destroying memslot...
--
Peter Xu
next prev parent reply other threads:[~2020-07-07 20:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 11:59 [PATCH v10 00/14] KVM: Dirty ring interface Peter Xu
2020-06-01 11:59 ` [PATCH v10 01/14] KVM: X86: Change parameter for fast_page_fault tracepoint Peter Xu
2020-06-01 11:59 ` [PATCH v10 02/14] KVM: Cache as_id in kvm_memory_slot Peter Xu
2020-07-02 23:08 ` Sean Christopherson
2020-07-03 18:41 ` Peter Xu
2020-07-07 6:17 ` Sean Christopherson
2020-07-07 19:50 ` Peter Xu
2020-07-07 19:56 ` Sean Christopherson
2020-07-07 20:15 ` Peter Xu
2020-07-07 20:26 ` Sean Christopherson
2020-07-07 20:38 ` Peter Xu [this message]
2020-06-01 11:59 ` [PATCH v10 03/14] KVM: X86: Don't track dirty for KVM_SET_[TSS_ADDR|IDENTITY_MAP_ADDR] Peter Xu
2020-07-03 0:05 ` Sean Christopherson
2020-07-03 19:02 ` Peter Xu
2020-06-01 11:59 ` [PATCH v10 04/14] KVM: Pass in kvm pointer into mark_page_dirty_in_slot() Peter Xu
2020-06-01 11:59 ` [PATCH v10 05/14] KVM: X86: Implement ring-based dirty memory tracking Peter Xu
2020-06-01 11:59 ` [PATCH v10 06/14] KVM: Make dirty ring exclusive to dirty bitmap log Peter Xu
2020-06-01 11:59 ` [PATCH v10 07/14] KVM: Don't allocate dirty bitmap if dirty ring is enabled Peter Xu
2020-06-01 11:59 ` [PATCH v10 08/14] KVM: selftests: Always clear dirty bitmap after iteration Peter Xu
2020-06-01 11:59 ` [PATCH v10 09/14] KVM: selftests: Sync uapi/linux/kvm.h to tools/ Peter Xu
2020-06-01 11:59 ` [PATCH v10 10/14] KVM: selftests: Use a single binary for dirty/clear log test Peter Xu
2020-06-01 11:59 ` [PATCH v10 11/14] KVM: selftests: Introduce after_vcpu_run hook for dirty " Peter Xu
2020-06-01 11:59 ` [PATCH v10 12/14] KVM: selftests: Add dirty ring buffer test Peter Xu
2020-06-01 12:05 ` [PATCH v10 13/14] KVM: selftests: Let dirty_log_test async for dirty ring test Peter Xu
2020-06-01 12:05 ` [PATCH v10 14/14] KVM: selftests: Add "-c" parameter to dirty log test Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707203823.GI88106@xz-x1 \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=drjones@redhat.com \
--cc=jasowang@redhat.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox