From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84BBFC433E0 for ; Thu, 9 Jul 2020 11:41:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B861206DF for ; Thu, 9 Jul 2020 11:41:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZHBYEEOR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726782AbgGILlK (ORCPT ); Thu, 9 Jul 2020 07:41:10 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:54872 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726541AbgGILlJ (ORCPT ); Thu, 9 Jul 2020 07:41:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594294868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9FS4nq3l74NvUGdG33Vk2HiCPbybnGoivD3bAOH9YxY=; b=ZHBYEEORaA6mct9PfYNcrIh3VmH/WInHbvFiafGuDvBSTrlzWeED2CNJRJnNO6mldwkjbb BZsfU7H0EYe2BbDQvaAGpglw/YEbi5ReA1B+fZ2sIG7A9qXZ3FkDLgKMzwPVR4Lj1wQPAn zaSVNKwBFi/YlHdcx3IAK08NX7Dqb98= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-447-tu2v7dA0MZ-0rLggUiWMFQ-1; Thu, 09 Jul 2020 07:41:06 -0400 X-MC-Unique: tu2v7dA0MZ-0rLggUiWMFQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2E7AD107ACF2; Thu, 9 Jul 2020 11:41:05 +0000 (UTC) Received: from gondolin (ovpn-113-62.ams2.redhat.com [10.36.113.62]) by smtp.corp.redhat.com (Postfix) with ESMTP id 867BB7F8BF; Thu, 9 Jul 2020 11:40:59 +0000 (UTC) Date: Thu, 9 Jul 2020 13:40:56 +0200 From: Cornelia Huck To: Pierre Morel Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, frankja@linux.ibm.com, david@redhat.com, thuth@redhat.com, drjones@redhat.com Subject: Re: [kvm-unit-tests PATCH v11 8/9] s390x: css: msch, enable test Message-ID: <20200709134056.0d267b6c.cohuck@redhat.com> In-Reply-To: <1594282068-11054-9-git-send-email-pmorel@linux.ibm.com> References: <1594282068-11054-1-git-send-email-pmorel@linux.ibm.com> <1594282068-11054-9-git-send-email-pmorel@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, 9 Jul 2020 10:07:47 +0200 Pierre Morel wrote: > A second step when testing the channel subsystem is to prepare a channel > for use. > This includes: > - Get the current subchannel Information Block (SCHIB) using STSCH > - Update it in memory to set the ENABLE bit and the specified ISC > - Tell the CSS that the SCHIB has been modified using MSCH > - Get the SCHIB from the CSS again to verify that the subchannel is > enabled and uses the specified ISC. > - If the command succeeds but subchannel is not enabled or the ISC > field is not as expected, retry a predefined retries count. > - If the command fails, report the failure and do not retry, even > if cc indicates a busy/status pending as we do not expect this. > > This tests the MSCH instruction to enable a channel successfully. > Retries are done and in case of error, and if the retries count > is exceeded, a report is made. > > Signed-off-by: Pierre Morel > Acked-by: Thomas Huth > Reviewed-by: Cornelia Huck > --- > lib/s390x/css.h | 8 +++-- > lib/s390x/css_lib.c | 72 +++++++++++++++++++++++++++++++++++++++++++++ > s390x/css.c | 15 ++++++++++ > 3 files changed, 92 insertions(+), 3 deletions(-) (...) > +/* > + * css_msch: enable subchannel and set with specified ISC "css_enable: enable the subchannel with the specified ISC" ? > + * @schid: Subchannel Identifier > + * @isc : number of the interruption subclass to use > + * Return value: > + * On success: 0 > + * On error the CC of the faulty instruction > + * or -1 if the retry count is exceeded. > + */ > +int css_enable(int schid, int isc) > +{ > + struct pmcw *pmcw = &schib.pmcw; > + int retry_count = 0; > + uint16_t flags; > + int cc; > + > + /* Read the SCHIB for this subchannel */ > + cc = stsch(schid, &schib); > + if (cc) { > + report_info("stsch: sch %08x failed with cc=%d", schid, cc); > + return cc; > + } > + > + flags = PMCW_ENABLE | (isc << PMCW_ISC_SHIFT); > + if ((pmcw->flags & flags) == flags) { I think you want (pmcw->flags & PMCW_ENABLE) == PMCW_ENABLE -- this catches the case of "subchannel has been enabled before, but with a different isc". > + report_info("stsch: sch %08x already enabled", schid); > + return 0; > + } (...)