From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org,
Sean Christopherson <sean.j.christopherson@intel.com>
Subject: [kvm-unit-tests PATCH] cstart: Fix typo in i386's cstart assembly
Date: Mon, 13 Jul 2020 21:19:05 -0700 [thread overview]
Message-ID: <20200714041905.12848-1-sean.j.christopherson@intel.com> (raw)
Replace a '%' with a '$' to encode a literal in when initializing CR4.
This fixes the build on i386 as gcc complains about a non-existent
register.
x86/cstart.S: Assembler messages:
x86/cstart.S:128: Error: bad register name `%(1<<4)'
Makefile:101: recipe for target 'x86/cstart.o' failed
Fixes: d86ef58519645 ("cstart: do not assume CR4 starts as zero")
Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
---
x86/cstart.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/x86/cstart.S b/x86/cstart.S
index e63e4e2..c0efc5f 100644
--- a/x86/cstart.S
+++ b/x86/cstart.S
@@ -125,7 +125,7 @@ start:
jmpl $8, $start32
prepare_32:
- mov %(1 << 4), %eax // pse
+ mov $(1 << 4), %eax // pse
mov %eax, %cr4
mov $pt, %eax
--
2.26.0
next reply other threads:[~2020-07-14 4:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 4:19 Sean Christopherson [this message]
2020-07-14 4:37 ` [kvm-unit-tests PATCH] cstart: Fix typo in i386's cstart assembly Nadav Amit
2020-07-15 14:31 ` Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714041905.12848-1-sean.j.christopherson@intel.com \
--to=sean.j.christopherson@intel.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox