From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8611CC433E2 for ; Wed, 15 Jul 2020 01:24:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 646C120663 for ; Wed, 15 Jul 2020 01:24:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="As6jd7uW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728155AbgGOBYr (ORCPT ); Tue, 14 Jul 2020 21:24:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726859AbgGOBYq (ORCPT ); Tue, 14 Jul 2020 21:24:46 -0400 Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78797C061755 for ; Tue, 14 Jul 2020 18:24:46 -0700 (PDT) Received: by mail-pf1-x442.google.com with SMTP id m9so676369pfh.0 for ; Tue, 14 Jul 2020 18:24:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=MV9eZ5OBgqTWIWwL9zpqkY6z/89bNn4vF0SnKjjFgTo=; b=As6jd7uWVm/c/uXeyIWNIkQkotsGzxOaaLvAOys2HbOeY1PyGOtFGLeOpMzbRY5fBW 7CLyuBD/uXM+ETluLcq0AobqVWwAOu6WOxc9qIb+eJ501gis6a1t3VHFTz+mJN4Shyf5 csynOX1q6Nqq6cA0TTETd6QbQtBcx5uQ7Pwsc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MV9eZ5OBgqTWIWwL9zpqkY6z/89bNn4vF0SnKjjFgTo=; b=rh9X5yFyR6M2vcskffNRjhcfLdO2IiX3WULUx/DJmFTsBUzQE/eG6kEiFtYPMU5wr6 UDVyYjZ76YUU3QmJnVfRYVqYjhmlXxlkHCk/ZWQU+Hugk1DilqtGnUE373WaY5U8p/3k +bjxL65DlHYzVVpXsiuJr7DIm2O+MJ6GY6DDgFs2+3KJdIAOz6F7sbqqbHUaQj9MEsUk xzO5TmDn1rhDoYzK/OOzXrfi0jOFr3+0EGzRg5XmkQcqMTDTnzThCxyIAHOx88akJx0t a/7MEffUk0GiXuWTbMGqe+U/1qJA5hhmHLbqEHDANRkWhipWopNAdfqguOEeMr+E81CN kmhw== X-Gm-Message-State: AOAM532tMRTSuxaQ3UPHVvBJ86Nxr2/FwVMzeOqhurbeMVjJ2Lqwp/rp bCgbjDu+jg1kxIfJGDMip2sBNQ== X-Google-Smtp-Source: ABdhPJwhN14rx8PS3l05EEyiO5yiHoXuh4AV1aLnKEa+PDj1AyXl4Y90zwpN7OBuitZH9VRBWPYvoQ== X-Received: by 2002:a63:eb52:: with SMTP id b18mr5523396pgk.434.1594776286032; Tue, 14 Jul 2020 18:24:46 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z2sm328776pfq.67.2020.07.14.18.24.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 18:24:45 -0700 (PDT) Date: Tue, 14 Jul 2020 18:24:44 -0700 From: Kees Cook To: Joerg Roedel Cc: x86@kernel.org, Joerg Roedel , hpa@zytor.com, Andy Lutomirski , Dave Hansen , Peter Zijlstra , Jiri Slaby , Dan Williams , Tom Lendacky , Juergen Gross , David Rientjes , Cfir Cohen , Erdem Aktas , Masami Hiramatsu , Mike Stunes , Sean Christopherson , Martin Radev , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v4 17/75] x86/boot/compressed/64: Change add_identity_map() to take start and end Message-ID: <202007141824.909CAE9EB@keescook> References: <20200714120917.11253-1-joro@8bytes.org> <20200714120917.11253-18-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200714120917.11253-18-joro@8bytes.org> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Jul 14, 2020 at 02:08:19PM +0200, Joerg Roedel wrote: > From: Joerg Roedel > > Changing the function to take start and end as parameters instead of > start and size simplifies the callers, which don't need to calculate > the size if they already have start and end. > > Signed-off-by: Joerg Roedel Reviewed-by: Kees Cook -- Kees Cook