From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: kvm@vger.kernel.org, pbonzini@redhat.com
Cc: frankja@linux.ibm.com, thuth@redhat.com, david@redhat.com,
drjones@redhat.com, jmattson@google.com,
sean.j.christopherson@intel.com
Subject: Re: [kvm-unit-tests PATCH v2 1/2] x86/cstart: Fix compilation issue in 32 bit mode
Date: Wed, 15 Jul 2020 16:29:31 +0200 [thread overview]
Message-ID: <20200715162931.4bd13f27@ibm-vm> (raw)
In-Reply-To: <20200714130030.56037-2-imbrenda@linux.ibm.com>
please disregard this patch, I had not noticed someone else had already
sent this same patch shortly before me
On Tue, 14 Jul 2020 15:00:29 +0200
Claudio Imbrenda <imbrenda@linux.ibm.com> wrote:
> Fix a typo in x86/cstart.S so that 32bit code can be compiled again
> on x86.
>
> Fixes: d86ef58519645 ("cstart: do not assume CR4 starts as zero")
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> ---
> x86/cstart.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/x86/cstart.S b/x86/cstart.S
> index e63e4e2..c0efc5f 100644
> --- a/x86/cstart.S
> +++ b/x86/cstart.S
> @@ -125,7 +125,7 @@ start:
> jmpl $8, $start32
>
> prepare_32:
> - mov %(1 << 4), %eax // pse
> + mov $(1 << 4), %eax // pse
> mov %eax, %cr4
>
> mov $pt, %eax
next prev parent reply other threads:[~2020-07-15 14:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 13:00 [kvm-unit-tests PATCH v2 0/2] Fix some compilation issues on 32bit Claudio Imbrenda
2020-07-14 13:00 ` [kvm-unit-tests PATCH v2 1/2] x86/cstart: Fix compilation issue in 32 bit mode Claudio Imbrenda
2020-07-15 14:29 ` Claudio Imbrenda [this message]
2020-07-14 13:00 ` [kvm-unit-tests PATCH v2 2/2] lib/alloc_page: Fix compilation issue on 32bit archs Claudio Imbrenda
2020-07-15 14:19 ` Thomas Huth
2020-07-16 7:11 ` Nadav Amit
2020-07-16 9:55 ` Claudio Imbrenda
2020-07-28 21:25 ` [kvm-unit-tests PATCH v2 0/2] Fix some compilation issues on 32bit Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715162931.4bd13f27@ibm-vm \
--to=imbrenda@linux.ibm.com \
--cc=david@redhat.com \
--cc=drjones@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).