Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: madhuparnabhowmik10@gmail.com,
	"Dexuan-Linux Cui" <dexuan.linux@gmail.com>,
	"Josh Triplett" <josh@joshtriplett.org>,
	"Joel Fernandes" <joel@joelfernandes.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	rcu@vger.kernel.org, "open list" <linux-kernel@vger.kernel.org>,
	"X86 ML" <x86@kernel.org>, "kvm list" <kvm@vger.kernel.org>,
	frextrite@gmail.com, lkft-triage@lists.linaro.org,
	"Dexuan Cui" <decui@microsoft.com>,
	juhlee@microsoft.com, "Daniel Díaz" <daniel.diaz@linaro.org>
Subject: Re: [PATCH 2/2] kvm: mmu: page_track: Fix RCU list API usage
Date: Fri, 17 Jul 2020 17:12:59 -0700	[thread overview]
Message-ID: <20200718001259.GY9247@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <CA+G9fYvtYr0ri6j-auNOTs98xVj-a1AoZtUfwokwnvuFFWtFdQ@mail.gmail.com>

On Sat, Jul 18, 2020 at 12:35:12AM +0530, Naresh Kamboju wrote:
> Hi Paul,
> 
> > I am not seeing this here.
> 
> Do you notice any warnings while building linux next master
> for x86_64 architecture ?

Idiot here was failing to enable building of KVM.  With that, I do see
the error.  The patch resolves it for me.  Does it help for you?

							Thanx, Paul

------------------------------------------------------------------------

diff --git a/include/linux/rculist.h b/include/linux/rculist.h
index de9385b..f8633d3 100644
--- a/include/linux/rculist.h
+++ b/include/linux/rculist.h
@@ -73,7 +73,7 @@ static inline void INIT_LIST_HEAD_RCU(struct list_head *list)
 #define __list_check_rcu(dummy, cond, extra...)				\
 	({ check_arg_count_one(extra); })
 
-#define __list_check_srcu(cond) true
+#define __list_check_srcu(cond) ({ })
 #endif
 
 /*

  reply	other threads:[~2020-07-18  0:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-12 13:10 [PATCH 1/2] rculist : Introduce list/hlist_for_each_entry_srcu() macros madhuparnabhowmik10
2020-07-12 13:10 ` [PATCH 2/2] kvm: mmu: page_track: Fix RCU list API usage madhuparnabhowmik10
2020-07-12 16:08   ` Paul E. McKenney
2020-07-16 14:44     ` Naresh Kamboju
2020-07-17  0:19       ` Dexuan-Linux Cui
2020-07-17 17:07         ` Paul E. McKenney
2020-07-17 18:03           ` Daniel Díaz
2020-07-17 18:25             ` Daniel Díaz
2020-07-17 19:05           ` Naresh Kamboju
2020-07-18  0:12             ` Paul E. McKenney [this message]
2020-07-19 12:22               ` Naresh Kamboju
2020-07-19 16:08                 ` Paul E. McKenney
2020-07-20 14:13                   ` Naresh Kamboju
2020-07-20 23:31                     ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200718001259.GY9247@paulmck-ThinkPad-P72 \
    --to=paulmck@kernel.org \
    --cc=daniel.diaz@linaro.org \
    --cc=decui@microsoft.com \
    --cc=dexuan.linux@gmail.com \
    --cc=frextrite@gmail.com \
    --cc=joel@joelfernandes.org \
    --cc=josh@joshtriplett.org \
    --cc=juhlee@microsoft.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkft-triage@lists.linaro.org \
    --cc=madhuparnabhowmik10@gmail.com \
    --cc=naresh.kamboju@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=rcu@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox