From: Cornelia Huck <cohuck@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>
Cc: kvm@vger.kernel.org, thuth@redhat.com,
linux-s390@vger.kernel.org, david@redhat.com,
borntraeger@de.ibm.com, imbrenda@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH v2 3/3] s390x: Ultravisor guest API test
Date: Mon, 10 Aug 2020 17:32:05 +0200 [thread overview]
Message-ID: <20200810173205.2daaaca1.cohuck@redhat.com> (raw)
In-Reply-To: <2b5634bf-c39b-13db-924a-5efcbaddb238@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]
On Mon, 10 Aug 2020 17:27:36 +0200
Janosch Frank <frankja@linux.ibm.com> wrote:
> On 8/10/20 4:50 PM, Cornelia Huck wrote:
> > On Fri, 7 Aug 2020 07:15:55 -0400
> > Janosch Frank <frankja@linux.ibm.com> wrote:
> >> +static inline int share(unsigned long addr, u16 cmd)
> >> +{
> >> + struct uv_cb_share uvcb = {
> >> + .header.cmd = cmd,
> >> + .header.len = sizeof(uvcb),
> >> + .paddr = addr
> >> + };
> >> +
> >> + uv_call(0, (u64)&uvcb);
> >> + return uvcb.header.rc;
> >
> > Any reason why you're not checking rc and cc here...
>
> Well, this is a helper function not a test function.
> Since I can only return one value and since I'm lazy, I chose to ignore
> the CC and went for the uvcb rc. That's basically also the answer for
> your following questions.
Maybe I'm just confused regarding the command execution here.
>
>
> Alright, I'll remove the helpers and execute those tests the hard way.
As a plus point, you see exactly what is being done.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-08-10 15:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 11:15 [kvm-unit-tests PATCH v2 0/3] PV tests part 1 Janosch Frank
2020-08-07 11:15 ` [kvm-unit-tests PATCH v2 1/3] s390x: Add custom pgm cleanup function Janosch Frank
2020-08-10 12:21 ` Cornelia Huck
2020-08-07 11:15 ` [kvm-unit-tests PATCH v2 2/3] s390x: skrf: Add exception new skey test and add test to unittests.cfg Janosch Frank
2020-08-07 12:12 ` Thomas Huth
2020-08-10 14:38 ` Cornelia Huck
2020-08-07 11:15 ` [kvm-unit-tests PATCH v2 3/3] s390x: Ultravisor guest API test Janosch Frank
2020-08-07 12:14 ` Thomas Huth
2020-08-10 14:50 ` Cornelia Huck
2020-08-10 15:27 ` Janosch Frank
2020-08-10 15:32 ` Cornelia Huck [this message]
2020-08-10 15:45 ` [kvm-unit-tests PATCH v3] " Janosch Frank
2020-08-10 15:50 ` Cornelia Huck
2020-08-11 7:18 ` Janosch Frank
2020-08-11 7:29 ` [kvm-unit-tests PATCH v2 0/3] PV tests part 1 Janosch Frank
-- strict thread matches above, loose matches on Subject: below --
2020-07-27 9:54 Janosch Frank
2020-07-27 9:54 ` [kvm-unit-tests PATCH v2 3/3] s390x: Ultravisor guest API test Janosch Frank
2020-07-30 11:16 ` Cornelia Huck
2020-07-30 15:58 ` Thomas Huth
2020-07-31 7:34 ` Janosch Frank
2020-07-31 8:42 ` Cornelia Huck
2020-07-31 9:06 ` Janosch Frank
2020-07-31 9:21 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200810173205.2daaaca1.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox