From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22EA3C433E1 for ; Mon, 17 Aug 2020 06:38:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE17C20716 for ; Mon, 17 Aug 2020 06:38:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Zp86t1G+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726703AbgHQGix (ORCPT ); Mon, 17 Aug 2020 02:38:53 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:55538 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726483AbgHQGiw (ORCPT ); Mon, 17 Aug 2020 02:38:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597646330; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p27bQOF4p6q5oYpRrHd1HKqo5O+sKCNmptEH4q2zCDY=; b=Zp86t1G+zPTmpEmcbhg5WMeLjaFqh0+GQ6BOI1A/cPUVHK0sL0j+rLFeKiBurukm6JfPqU xrcBGaOHNO+PXJ3nuHF+aP3tyJVvEeZ9nRLLuXhrUMKbb/aeNcIQrXbZbsKSsXwT48NTyV sNHsEZa/cizjs/DBRqVfJWZQ5tacOH8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-148-LJkz_mXvMI2EhpfIOLxf7g-1; Mon, 17 Aug 2020 02:38:48 -0400 X-MC-Unique: LJkz_mXvMI2EhpfIOLxf7g-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E053D801AAC; Mon, 17 Aug 2020 06:38:45 +0000 (UTC) Received: from gondolin (ovpn-112-230.ams2.redhat.com [10.36.112.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id 896B65C1DC; Mon, 17 Aug 2020 06:38:30 +0000 (UTC) Date: Mon, 17 Aug 2020 08:38:28 +0200 From: Cornelia Huck To: Eric Farman Cc: Sean Mooney , Jiri Pirko , Yan Zhao , Jason Wang , Alex Williamson , kvm@vger.kernel.org, libvir-list@redhat.com, qemu-devel@nongnu.org, kwankhede@nvidia.com, eauger@redhat.com, xin-ran.wang@intel.com, corbet@lwn.net, openstack-discuss@lists.openstack.org, shaohe.feng@intel.com, kevin.tian@intel.com, eskultet@redhat.com, jian-feng.ding@intel.com, dgilbert@redhat.com, zhenyuw@linux.intel.com, hejie.xu@intel.com, bao.yumeng@zte.com.cn, intel-gvt-dev@lists.freedesktop.org, berrange@redhat.com, dinechin@redhat.com, devel@ovirt.org, Parav Pandit Subject: Re: device compatibility interface for live migration with assigned devices Message-ID: <20200817083828.187315ef.cohuck@redhat.com> In-Reply-To: <315669b0-5c75-d359-a912-62ebab496abf@linux.ibm.com> References: <20200727072440.GA28676@joy-OptiPlex-7040> <20200727162321.7097070e@x1.home> <20200729080503.GB28676@joy-OptiPlex-7040> <20200804183503.39f56516.cohuck@redhat.com> <20200805021654.GB30485@joy-OptiPlex-7040> <2624b12f-3788-7e2b-2cb7-93534960bcb7@redhat.com> <20200805075647.GB2177@nanopsycho> <20200805093338.GC30485@joy-OptiPlex-7040> <20200805105319.GF2177@nanopsycho> <4cf2824c803c96496e846c5b06767db305e9fb5a.camel@redhat.com> <20200807135942.5d56a202.cohuck@redhat.com> <20200813173347.239801fa.cohuck@redhat.com> <315669b0-5c75-d359-a912-62ebab496abf@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, 13 Aug 2020 15:02:53 -0400 Eric Farman wrote: > On 8/13/20 11:33 AM, Cornelia Huck wrote: > > On Fri, 7 Aug 2020 13:59:42 +0200 > > Cornelia Huck wrote: > > > >> On Wed, 05 Aug 2020 12:35:01 +0100 > >> Sean Mooney wrote: > >> > >>> On Wed, 2020-08-05 at 12:53 +0200, Jiri Pirko wrote: > >>>> Wed, Aug 05, 2020 at 11:33:38AM CEST, yan.y.zhao@intel.com wrote: > >> > >> (...) > >> > >>>>> software_version: device driver's version. > >>>>> in .[.bugfix] scheme, where there is no > >>>>> compatibility across major versions, minor versions have > >>>>> forward compatibility (ex. 1-> 2 is ok, 2 -> 1 is not) and > >>>>> bugfix version number indicates some degree of internal > >>>>> improvement that is not visible to the user in terms of > >>>>> features or compatibility, > >>>>> > >>>>> vendor specific attributes: each vendor may define different attributes > >>>>> device id : device id of a physical devices or mdev's parent pci device. > >>>>> it could be equal to pci id for pci devices > >>>>> aggregator: used together with mdev_type. e.g. aggregator=2 together > >>>>> with i915-GVTg_V5_4 means 2*1/4=1/2 of a gen9 Intel > >>>>> graphics device. > >>>>> remote_url: for a local NVMe VF, it may be configured with a remote > >>>>> url of a remote storage and all data is stored in the > >>>>> remote side specified by the remote url. > >>>>> ... > >>> just a minor not that i find ^ much more simmple to understand then > >>> the current proposal with self and compatiable. > >>> if i have well defiend attibute that i can parse and understand that allow > >>> me to calulate the what is and is not compatible that is likely going to > >>> more useful as you wont have to keep maintianing a list of other compatible > >>> devices every time a new sku is released. > >>> > >>> in anycase thank for actully shareing ^ as it make it simpler to reson about what > >>> you have previously proposed. > >> > >> So, what would be the most helpful format? A 'software_version' field > >> that follows the conventions outlined above, and other (possibly > >> optional) fields that have to match? > > > > Just to get a different perspective, I've been trying to come up with > > what would be useful for a very different kind of device, namely > > vfio-ccw. (Adding Eric to cc: for that.) > > > > software_version makes sense for everybody, so it should be a standard > > attribute. > > > > For the vfio-ccw type, we have only one vendor driver (vfio-ccw_IO). > > > > Given a subchannel A, we want to make sure that subchannel B has a > > reasonable chance of being compatible. I guess that means: > > > > - same subchannel type (I/O) > > - same chpid type (e.g. all FICON; I assume there are no 'mixed' setups > > -- Eric?) > > Correct. > > > - same number of chpids? Maybe we can live without that and just inject > > some machine checks, I don't know. Same chpid numbers is something we > > cannot guarantee, especially if we want to migrate cross-CEC (to > > another machine.) > > I think we'd live without it, because I wouldn't expect it to be > consistent between systems. Yes, and the guest needs to be able to deal with changing path configurations anyway. > > > > > Other possibly interesting information is not available at the > > subchannel level (vfio-ccw is a subchannel driver.) > > I presume you're alluding to the DASD uid (dasdinfo -x) here? Yes, or the even more basic Sense ID information. > > > > > So, looking at a concrete subchannel on one of my machines, it would > > look something like the following: > > > > > > software_version=1.0.0 > > type=vfio-ccw <-- would be vfio-pci on the example above > > > > subchannel_type=0 > > > > chpid_type=0x1a > > chpid_mask=0xf0 <-- not sure if needed/wanted Let's just drop the chpid_mask here. > > > > Does that make sense? Would be interesting if someone could come up with some possible information for a third type of device.