Re: [PATCH 8/8] KVM: nSVM: read only changed fields of the nested guest data area

Maxim Levitsky
2020-08-20T12:11:42Z

On Thu, 2020-08-20 at 11:55 +0200, Paolo Bonzini wrote:
> On 20/08/20 11:13, Maxim Levitsky wrote:
> > diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
> > index 06668e0f93e7..f0bb7f622dca 100644
> > --- a/arch/x86/kvm/svm/svm.c
> > +++ b/arch/x86/kvm/svm/svm.c
> > @@ -3924,7 +3924,7 @@ static int svm_pre_leave_smm(struct kvm_vcpu *vcpu, const char *smstate)
> > if (kvm_vcpu_map(&svm->vcpu, gpa_to_gfn(vmcb_gpa), &map) == -EINVAL)
> > return 1;
> >
> > - load_nested_vmcb(svm, map.hva, vmcb);
> > + load_nested_vmcb(svm, map.hva, vmcb_gpa);
> > ret = enter_svm_guest_mode(svm);
> >
>
> Wrong patch?

Absolutely. I reordered the refactoring patches to be at the beginning,
and didn't test this enough.

Best regards,
Maxim Levitsky

>
> Paolo
>