From: Marc Hartmayer <mhartmay@linux.ibm.com>
To: <kvm@vger.kernel.org>
Cc: Thomas Huth <thuth@redhat.com>,
David Hildenbrand <david@redhat.com>,
Janosch Frank <frankja@linux.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
Andrew Jones <drjones@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [kvm-unit-tests PATCH 2/2] Use same test names in the default and the TAP13 output format
Date: Fri, 21 Aug 2020 14:37:44 +0200 [thread overview]
Message-ID: <20200821123744.33173-3-mhartmay@linux.ibm.com> (raw)
In-Reply-To: <20200821123744.33173-1-mhartmay@linux.ibm.com>
Use the same test names in the TAP13 output as in the default output
format. This makes the output more consistent. To achieve this, we
need to pass the test name as an argument to the function
`process_test_output`.
Before this change:
$ ./run_tests.sh
PASS selftest-setup (14 tests)
...
vs.
$ ./run_tests.sh -t
TAP version 13
ok 1 - selftest: true
ok 2 - selftest: argc == 3
...
After this change:
$ ./run_tests.sh
PASS selftest-setup (14 tests)
...
vs.
$ ./run_tests.sh -t
TAP version 13
ok 1 - selftest-setup: true
ok 2 - selftest-setup: argc == 3
...
While at it, introduce a local variable `kernel` in
`RUNTIME_log_stdout` since this makes the function easier to read.
Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
---
run_tests.sh | 15 +++++++++------
scripts/runtime.bash | 6 +++---
2 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/run_tests.sh b/run_tests.sh
index 01e36dcfa06e..b5812336866f 100755
--- a/run_tests.sh
+++ b/run_tests.sh
@@ -81,18 +81,19 @@ if [[ $tap_output == "no" ]]; then
postprocess_suite_output() { cat; }
else
process_test_output() {
+ local testname="$1"
CR=$'\r'
while read -r line; do
line="${line%$CR}"
case "${line:0:4}" in
PASS)
- echo "ok TEST_NUMBER - ${line#??????}" >&3
+ echo "ok TEST_NUMBER - ${testname}:${line#*:*:}" >&3
;;
FAIL)
- echo "not ok TEST_NUMBER - ${line#??????}" >&3
+ echo "not ok TEST_NUMBER - ${testname}:${line#*:*:}" >&3
;;
SKIP)
- echo "ok TEST_NUMBER - ${line#??????} # skip" >&3
+ echo "ok TEST_NUMBER - ${testname}:${line#*:*:} # skip" >&3
;;
*)
;;
@@ -114,12 +115,14 @@ else
}
fi
-RUNTIME_log_stderr () { process_test_output; }
+RUNTIME_log_stderr () { process_test_output "$1"; }
RUNTIME_log_stdout () {
+ local testname="$1"
if [ "$PRETTY_PRINT_STACKS" = "yes" ]; then
- ./scripts/pretty_print_stacks.py $1 | process_test_output
+ local kernel="$2"
+ ./scripts/pretty_print_stacks.py "$kernel" | process_test_output "$testname"
else
- process_test_output
+ process_test_output "$testname"
fi
}
diff --git a/scripts/runtime.bash b/scripts/runtime.bash
index caa4c5ba18cc..294e6b15a5e2 100644
--- a/scripts/runtime.bash
+++ b/scripts/runtime.bash
@@ -140,10 +140,10 @@ function run()
# extra_params in the config file may contain backticks that need to be
# expanded, so use eval to start qemu. Use "> >(foo)" instead of a pipe to
# preserve the exit status.
- summary=$(eval $cmdline 2> >(RUNTIME_log_stderr) \
- > >(tee >(RUNTIME_log_stdout $kernel) | extract_summary))
+ summary=$(eval $cmdline 2> >(RUNTIME_log_stderr $testname) \
+ > >(tee >(RUNTIME_log_stdout $testname $kernel) | extract_summary))
ret=$?
- [ "$STANDALONE" != "yes" ] && echo > >(RUNTIME_log_stdout $kernel)
+ [ "$STANDALONE" != "yes" ] && echo > >(RUNTIME_log_stdout $testname $kernel)
if [ $ret -eq 0 ]; then
print_result "PASS" $testname "$summary"
--
2.25.4
next prev parent reply other threads:[~2020-08-21 12:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 12:37 [kvm-unit-tests PATCH 0/2] Use same test names in the default and the TAP13 output format Marc Hartmayer
2020-08-21 12:37 ` [kvm-unit-tests PATCH 1/2] runtime.bash: remove outdated comment Marc Hartmayer
2020-08-21 13:16 ` Andrew Jones
2020-08-24 12:48 ` Cornelia Huck
2020-08-21 12:37 ` Marc Hartmayer [this message]
2020-08-21 13:16 ` [kvm-unit-tests PATCH 2/2] Use same test names in the default and the TAP13 output format Andrew Jones
2020-08-21 14:05 ` Janosch Frank
2020-08-21 14:16 ` Marc Hartmayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200821123744.33173-3-mhartmay@linux.ibm.com \
--to=mhartmay@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=drjones@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox