From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC90EC433E2 for ; Fri, 28 Aug 2020 06:54:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FE5320825 for ; Fri, 28 Aug 2020 06:54:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=yadro.com header.i=@yadro.com header.b="TQrZkH5z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726834AbgH1GyV (ORCPT ); Fri, 28 Aug 2020 02:54:21 -0400 Received: from mta-02.yadro.com ([89.207.88.252]:35910 "EHLO mta-01.yadro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725969AbgH1GyV (ORCPT ); Fri, 28 Aug 2020 02:54:21 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-01.yadro.com (Postfix) with ESMTP id DE0805752C; Fri, 28 Aug 2020 06:54:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yadro.com; h= in-reply-to:content-disposition:content-type:content-type :mime-version:references:message-id:subject:subject:from:from :date:date:received:received:received; s=mta-01; t=1598597658; x=1600412059; bh=QMs65RhVEG0A9ziXHBh7u6OK6hoUSKLGyEXZsuwPe+Q=; b= TQrZkH5zwP6OUQ0LQZbyu5fUTk2ExEHqDT+0LIMrvLAIZvwzD8lgM9afA9AFSTBg sNf2zeFZfOks1N/dBg0RCcIywfXoC3gbzX0gvqz2ztQcwNigS45lR5uAe27LRw7s VVQELrPiwvxwZkT0nJA54tHpgJ3kF5TZm5/fTk3AlmE= X-Virus-Scanned: amavisd-new at yadro.com Received: from mta-01.yadro.com ([127.0.0.1]) by localhost (mta-01.yadro.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SCM-P_xGRpcw; Fri, 28 Aug 2020 09:54:18 +0300 (MSK) Received: from T-EXCH-02.corp.yadro.com (t-exch-02.corp.yadro.com [172.17.10.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mta-01.yadro.com (Postfix) with ESMTPS id 42C04574E7; Fri, 28 Aug 2020 09:54:18 +0300 (MSK) Received: from localhost (172.17.204.212) by T-EXCH-02.corp.yadro.com (172.17.10.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.32; Fri, 28 Aug 2020 09:54:18 +0300 Date: Fri, 28 Aug 2020 09:54:17 +0300 From: Roman Bolshakov To: Thomas Huth CC: , Cameron Esfahani Subject: Re: [kvm-unit-tests PATCH 1/7] x86: Makefile: Allow division on x86_64-elf binutils Message-ID: <20200828065417.GA54274@SPB-NB-133.local> References: <20200810130618.16066-1-r.bolshakov@yadro.com> <20200810130618.16066-2-r.bolshakov@yadro.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Originating-IP: [172.17.204.212] X-ClientProxiedBy: T-EXCH-01.corp.yadro.com (172.17.10.101) To T-EXCH-02.corp.yadro.com (172.17.10.102) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Aug 28, 2020 at 07:00:19AM +0200, Thomas Huth wrote: > On 10/08/2020 15.06, Roman Bolshakov wrote: > > For compatibility with other SVR4 assemblers, '/' starts a comment on > > *-elf binutils target and thus division operator is not allowed [1][2]. > > That breaks cstart64.S build: > > > > x86/cstart64.S: Assembler messages: > > x86/cstart64.S:294: Error: unbalanced parenthesis in operand 1. > > > > The option is ignored on the Linux target of GNU binutils. > > > > 1. https://sourceware.org/binutils/docs/as/i386_002dChars.html > > 2. https://sourceware.org/binutils/docs/as/i386_002dOptions.html#index-_002d_002ddivide-option_002c-i386 > > > > Cc: Cameron Esfahani > > Signed-off-by: Roman Bolshakov > > --- > > x86/Makefile | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/x86/Makefile b/x86/Makefile > > index 8a007ab..22afbb9 100644 > > --- a/x86/Makefile > > +++ b/x86/Makefile > > @@ -1 +1,3 @@ > > include $(SRCDIR)/$(TEST_DIR)/Makefile.$(ARCH) > > + > > +COMMON_CFLAGS += -Wa,--divide > > Some weeks ago, I also played with an elf cross compiler and came to the > same conclusion, that we need this option there. Unfortunately, it does > not work with clang: > > https://gitlab.com/huth/kvm-unit-tests/-/jobs/707986800#L1629 > > You could try to wrap it with "cc-option" instead ... or use a proper > check in the configure script to detect whether it's needed or not. > Hi Thomas, Thanks for reviewing the series. I'll look into both options and will test with both gcc and clang afterwards. I can also update .travis.yml in a new patch to test the build on macOS. > And can you please put it next to the other COMMON_CFLAGS in > x86/Makefile.common instead of x86/Makefile? > Sure. Regards, Roman