public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: "Maoming (maoming,
	Cloud Infrastructure Service Product Dept.)" 
	<maoming.maoming@huawei.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
	"cohuck@redhat.com" <cohuck@redhat.com>,
	"Zhoujian (jay)" <jianjay.zhou@huawei.com>,
	"Huangweidong (C)" <weidong.huang@huawei.com>,
	"aarcange@redhat.com" <aarcange@redhat.com>,
	wangyunjian <wangyunjian@huawei.com>
Subject: Re: 答复: 答复: [PATCH V2] vfio dma_map/unmap: optimized for hugetlbfs pages
Date: Fri, 28 Aug 2020 10:24:00 -0400	[thread overview]
Message-ID: <20200828142400.GA3197@xz-x1> (raw)
In-Reply-To: <8B561EC9A4D13649A62CF60D3A8E8CB28C2DBE7A@dggeml524-mbx.china.huawei.com>

On Fri, Aug 28, 2020 at 09:23:08AM +0000, Maoming (maoming, Cloud Infrastructure Service Product Dept.) wrote:
> In hugetlb_put_pfn(), I delete unpin_user_pages_dirty_lock() and use some simple code to put hugetlb pages.
> Is this right?

I think we should still use the APIs because of the the same reason.  However
again I don't know the performance impact of that to your patch, but I still
think that could be done inside gup itself when needed (e.g., a special path
for hugetlbfs for [un]pinning continuous pages; though if that's the case that
could be something to be discussed on -mm then as a separate patch, imho).

Thanks,

-- 
Peter Xu


  reply	other threads:[~2020-08-28 14:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-14  2:37 [PATCH V2] vfio dma_map/unmap: optimized for hugetlbfs pages Ming Mao
2020-08-20 18:38 ` Alex Williamson
2020-08-28  9:23   ` 答复: " Maoming (maoming, Cloud Infrastructure Service Product Dept.)
2020-08-25 20:59 ` Peter Xu
2020-08-26 13:56   ` 答复: " Maoming (maoming, Cloud Infrastructure Service Product Dept.)
2020-08-26 15:15     ` Peter Xu
2020-08-28  9:23       ` 答复: " Maoming (maoming, Cloud Infrastructure Service Product Dept.)
2020-08-28 14:24         ` Peter Xu [this message]
2020-09-01  2:40           ` Jason Wang
2020-09-01 12:10             ` 答复: " Maoming (maoming, Cloud Infrastructure Service Product Dept.)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200828142400.GA3197@xz-x1 \
    --to=peterx@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=jianjay.zhou@huawei.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maoming.maoming@huawei.com \
    --cc=wangyunjian@huawei.com \
    --cc=weidong.huang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox