Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Roman Bolshakov <r.bolshakov@yadro.com>
To: Thomas Huth <thuth@redhat.com>
Cc: <kvm@vger.kernel.org>, Cameron Esfahani <dirty@apple.com>
Subject: Re: [kvm-unit-tests PATCH 1/7] x86: Makefile: Allow division on x86_64-elf binutils
Date: Mon, 31 Aug 2020 20:30:58 +0300	[thread overview]
Message-ID: <20200831173058.GA22344@SPB-NB-133.local> (raw)
In-Reply-To: <ee81540c-9064-4650-8784-d4531eec042c@redhat.com>

On Fri, Aug 28, 2020 at 07:00:19AM +0200, Thomas Huth wrote:
> On 10/08/2020 15.06, Roman Bolshakov wrote:
> > +
> > +COMMON_CFLAGS += -Wa,--divide
> 
> Some weeks ago, I also played with an elf cross compiler and came to the
> same conclusion, that we need this option there. Unfortunately, it does
> not work with clang:
> 
>  https://gitlab.com/huth/kvm-unit-tests/-/jobs/707986800#L1629
> 
> You could try to wrap it with "cc-option" instead ... or use a proper
> check in the configure script to detect whether it's needed or not.
> 

Hi Thomas,

I've wrapped it but clang can't deal with another option:
-Woverride-init

Even if I wrap it with cc-option and add wrapped clang's
-Winitializer-overrides, the build fails with:

x86/vmexit.c:577:5: error: no previous prototype for function 'main'
      [-Werror,-Wmissing-prototypes]
int main(int ac, char **av)
    ^
1 error generated.
<builtin>: recipe for target 'x86/vmexit.o' failed

I'm puzzled with this one.

CI log (ubuntu focal + clang 10):
https://travis-ci.com/github/roolebo/kvm-unit-tests/jobs/379561410

Now I wonder if wrong clang is used... Perhaps I should try
--cc=clang-10 in .travis.yml instead of --cc=clang.

Thanks,
Roman

  parent reply	other threads:[~2020-08-31 17:31 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-10 13:06 [kvm-unit-tests PATCH 0/7] Add support for generic ELF cross-compiler Roman Bolshakov
2020-08-10 13:06 ` [kvm-unit-tests PATCH 1/7] x86: Makefile: Allow division on x86_64-elf binutils Roman Bolshakov
2020-08-28  5:00   ` Thomas Huth
2020-08-28  6:54     ` Roman Bolshakov
2020-08-28  7:24       ` Thomas Huth
2020-08-28  7:47         ` Roman Bolshakov
2020-08-28  7:56           ` Thomas Huth
2020-08-28  8:37             ` Roman Bolshakov
2020-08-31 17:30     ` Roman Bolshakov [this message]
2020-08-31 20:33       ` Thomas Huth
2020-08-10 13:06 ` [kvm-unit-tests PATCH 2/7] x86: Replace instruction prefixes with spaces Roman Bolshakov
2020-08-28  4:34   ` Thomas Huth
2020-08-10 13:06 ` [kvm-unit-tests PATCH 3/7] x86: Makefile: Fix linkage of realmode on x86_64-elf binutils Roman Bolshakov
2020-08-28  5:44   ` Thomas Huth
2020-08-10 13:06 ` [kvm-unit-tests PATCH 4/7] lib: Bundle debugreg.h from the kernel Roman Bolshakov
2020-08-28  4:56   ` Thomas Huth
2020-08-10 13:06 ` [kvm-unit-tests PATCH 5/7] lib: x86: Use portable format macros for uint32_t Roman Bolshakov
2020-08-28  5:49   ` Thomas Huth
2020-08-10 13:06 ` [kvm-unit-tests PATCH 6/7] configure: Add an option to specify getopt Roman Bolshakov
2020-08-28  5:55   ` Thomas Huth
2020-08-28  7:12     ` Roman Bolshakov
2020-08-28  7:34       ` Thomas Huth
2020-08-10 13:06 ` [kvm-unit-tests PATCH 7/7] README: Update build instructions for macOS Roman Bolshakov
2020-08-26 16:52 ` [kvm-unit-tests PATCH 0/7] Add support for generic ELF cross-compiler Roman Bolshakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200831173058.GA22344@SPB-NB-133.local \
    --to=r.bolshakov@yadro.com \
    --cc=dirty@apple.com \
    --cc=kvm@vger.kernel.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox