From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Cc: kvm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
virtualization@lists.linux-foundation.org,
sound-open-firmware@alsa-project.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Vincent Whitchurch <vincent.whitchurch@axis.com>
Subject: Re: [PATCH v6 3/4] rpmsg: update documentation
Date: Thu, 3 Sep 2020 13:21:22 -0600 [thread overview]
Message-ID: <20200903192122.GA333030@xps15> (raw)
In-Reply-To: <20200901151153.28111-4-guennadi.liakhovetski@linux.intel.com>
On Tue, Sep 01, 2020 at 05:11:52PM +0200, Guennadi Liakhovetski wrote:
> rpmsg_create_ept() takes struct rpmsg_channel_info chinfo as its last
> argument, not a u32 value. The first two arguments are also updated.
>
> Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
> ---
> Documentation/rpmsg.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/rpmsg.txt b/Documentation/rpmsg.txt
> index 24b7a9e1a5f9..1ce353cb232a 100644
> --- a/Documentation/rpmsg.txt
> +++ b/Documentation/rpmsg.txt
> @@ -192,9 +192,9 @@ Returns 0 on success and an appropriate error value on failure.
>
> ::
>
> - struct rpmsg_endpoint *rpmsg_create_ept(struct rpmsg_channel *rpdev,
> - void (*cb)(struct rpmsg_channel *, void *, int, void *, u32),
> - void *priv, u32 addr);
> + struct rpmsg_endpoint *rpmsg_create_ept(struct rpmsg_device *rpdev,
> + rpmsg_rx_cb_t cb, void *priv,
> + struct rpmsg_channel_info chinfo);
>
I added my RB tag to this patch in V3.
> every rpmsg address in the system is bound to an rx callback (so when
> inbound messages arrive, they are dispatched by the rpmsg bus using the
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-09-03 19:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 15:11 [PATCH v6 0/4] Add a vhost RPMsg API Guennadi Liakhovetski
2020-09-01 15:11 ` [PATCH v6 1/4] vhost: convert VHOST_VSOCK_SET_RUNNING to a generic ioctl Guennadi Liakhovetski
2020-09-01 15:11 ` [PATCH v6 2/4] rpmsg: move common structures and defines to headers Guennadi Liakhovetski
2020-09-01 17:23 ` Mathieu Poirier
2020-09-02 5:35 ` Guennadi Liakhovetski
2020-09-02 17:24 ` Mathieu Poirier
2020-09-03 5:51 ` Guennadi Liakhovetski
2020-09-03 19:27 ` Mathieu Poirier
2020-09-01 15:11 ` [PATCH v6 3/4] rpmsg: update documentation Guennadi Liakhovetski
2020-09-03 19:21 ` Mathieu Poirier [this message]
2020-09-01 15:11 ` [PATCH v6 4/4] vhost: add an RPMsg API Guennadi Liakhovetski
2020-09-15 12:13 ` [PATCH v6 0/4] Add a vhost " Arnaud POULIQUEN
[not found] ` <20200917054705.GA11491@ubuntu>
2020-09-17 8:36 ` Vincent Whitchurch
2020-09-17 10:29 ` Guennadi Liakhovetski
2020-09-17 15:21 ` Arnaud POULIQUEN
[not found] ` <20200918054420.GA19246@ubuntu>
2020-09-18 7:47 ` Arnaud POULIQUEN
[not found] ` <20200918094719.GD19246@ubuntu>
2020-09-18 10:39 ` Vincent Whitchurch
2020-09-18 11:02 ` Guennadi Liakhovetski
2020-09-18 17:26 ` Arnaud POULIQUEN
2020-10-01 17:57 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200903192122.GA333030@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mst@redhat.com \
--cc=ohad@wizery.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=vincent.whitchurch@axis.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox