From: Heiko Carstens <hca@linux.ibm.com>
To: Janosch Frank <frankja@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, borntraeger@de.ibm.com,
gor@linux.ibm.com, imbrenda@linux.ibm.com, kvm@vger.kernel.org,
david@redhat.com
Subject: Re: [PATCH 2/2] s390x: Add 3f program exception handler
Date: Fri, 4 Sep 2020 14:14:22 +0200 [thread overview]
Message-ID: <20200904121422.GG6075@osiris> (raw)
In-Reply-To: <36e1c11c-c4a2-6ae2-b341-7d582203d031@linux.ibm.com>
On Fri, Sep 04, 2020 at 01:33:28PM +0200, Janosch Frank wrote:
> >> + printk_ratelimited(KERN_WARNING
> >> + "Secure storage violation in task: %s, pid %d\n",
> >> + get_task_comm(buf, current), task_pid_nr(current));
> >
> > Why get_task_comm() and task_pid_nr() instead of simply current->comm
> > and current->pid?
>
> Normally if there are functions to get data I assume those should be used.
Could be used, however I don't see why you need that extra complexity
here for both of them.
> > Also: is the dmesg message of any value?
> Yes, it's import for administrators to know that an exception caused
> this segfault and not some memory shenanigans.
>
> As the exception only occurs if a guest runs in unsupported modes like
> sharing the memory between two secure guests it's a good first
> indication what went wrong.
Yes, fine with me. Just not sure of how help this is when pid
namespaces come into play...
prev parent reply other threads:[~2020-09-04 12:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 13:14 [PATCH 0/2] s390x: pv: Fixes and improvements Janosch Frank
2020-09-03 13:14 ` [PATCH 1/2] s390x: uv: Add destroy page call Janosch Frank
2020-09-04 10:39 ` Heiko Carstens
2020-09-04 11:38 ` Janosch Frank
2020-09-04 12:10 ` Heiko Carstens
2020-09-07 9:50 ` Janosch Frank
2020-09-03 13:14 ` [PATCH 2/2] s390x: Add 3f program exception handler Janosch Frank
2020-09-03 14:20 ` Christian Borntraeger
2020-09-04 10:35 ` Heiko Carstens
2020-09-04 11:33 ` Janosch Frank
2020-09-04 12:14 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200904121422.GG6075@osiris \
--to=hca@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox