From: Cornelia Huck <cohuck@redhat.com>
To: Zenghui Yu <yuzenghui@huawei.com>
Cc: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<alex.williamson@redhat.com>, <wanghaibin.wang@huawei.com>
Subject: Re: [PATCH 2/2] vfio/pci: Remove bardirty from vfio_pci_device
Date: Thu, 17 Sep 2020 13:35:37 +0200 [thread overview]
Message-ID: <20200917133537.17af2ef3.cohuck@redhat.com> (raw)
In-Reply-To: <20200917033128.872-2-yuzenghui@huawei.com>
On Thu, 17 Sep 2020 11:31:28 +0800
Zenghui Yu <yuzenghui@huawei.com> wrote:
> It isn't clear what purpose the @bardirty serves. It might be used to avoid
> the unnecessary vfio_bar_fixup() invoking on a user-space BAR read, which
> is not required when bardirty is unset.
>
> The variable was introduced in commit 89e1f7d4c66d ("vfio: Add PCI device
> driver") but never actually used, so it shouldn't be that important. Remove
> it.
>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
> drivers/vfio/pci/vfio_pci_config.c | 7 -------
> drivers/vfio/pci/vfio_pci_private.h | 1 -
> 2 files changed, 8 deletions(-)
Yes, it seems to have been write-only all the time.
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2020-09-17 11:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 3:31 [PATCH 1/2] vfio/pci: Remove redundant declaration of vfio_pci_driver Zenghui Yu
2020-09-17 3:31 ` [PATCH 2/2] vfio/pci: Remove bardirty from vfio_pci_device Zenghui Yu
2020-09-17 11:35 ` Cornelia Huck [this message]
2020-09-17 22:07 ` Alex Williamson
2020-09-19 1:54 ` Zenghui Yu
2020-09-19 2:11 ` Alex Williamson
2020-09-19 2:39 ` Zenghui Yu
2020-09-17 11:26 ` [PATCH 1/2] vfio/pci: Remove redundant declaration of vfio_pci_driver Cornelia Huck
2020-09-17 22:22 ` Alex Williamson
2020-09-19 1:56 ` Zenghui Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917133537.17af2ef3.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wanghaibin.wang@huawei.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox