From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76545C2D0E2 for ; Tue, 22 Sep 2020 08:19:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 09C2523A1E for ; Tue, 22 Sep 2020 08:19:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="G6yqo5rn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726655AbgIVITi (ORCPT ); Tue, 22 Sep 2020 04:19:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:55585 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726483AbgIVITh (ORCPT ); Tue, 22 Sep 2020 04:19:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600762776; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=4YxfviHUp394Z95tLmiMsBjGp7nI/wBJIRQLvk3IHGM=; b=G6yqo5rn/OXcWbNArHhAkvUvGkR21dftZ8YcEO9u/bNEgfiUhjF8z8BUUggLxtzKMrtFi3 9o4LHsv9lhQEhovHYIgtBiHqRBSnc44rrNvK2p8MyK00Z3voEq63sF+cXXLW6EyNA11/ak irTH5UNiO+/H/3W7JAM52SSIkQzmnlE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-581-sAd04_3bMH6jFWidZ6f72A-1; Tue, 22 Sep 2020 04:19:34 -0400 X-MC-Unique: sAd04_3bMH6jFWidZ6f72A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C107D57053; Tue, 22 Sep 2020 08:19:29 +0000 (UTC) Received: from redhat.com (ovpn-114-64.ams2.redhat.com [10.36.114.64]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D54905C225; Tue, 22 Sep 2020 08:18:52 +0000 (UTC) Date: Tue, 22 Sep 2020 09:18:49 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Paolo Bonzini Cc: David Hildenbrand , Stefan Hajnoczi , qemu-devel@nongnu.org, Fam Zheng , Peter Maydell , sheepdog@lists.wpkg.org, kvm@vger.kernel.org, "Michael S. Tsirkin" , Jason Wang , Yuval Shaia , Markus Armbruster , Max Filippov , Alistair Francis , Gerd Hoffmann , Huacai Chen , Stefano Stabellini , Alberto Garcia , Sagar Karandikar , Yoshinori Sato , Juan Quintela , Jiri Slaby , Paul Durrant , Michael Roth , Halil Pasic , Christian Borntraeger , Aleksandar Markovic , Thomas Huth , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Matthew Rosato , Aleksandar Rikalo , Eduardo Habkost , Stefan Weil , Peter Lieven , "Dr. David Alan Gilbert" , Anthony Perard , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Liu Yuan , qemu-riscv@nongnu.org, Sunil Muthuswamy , John Snow , Hailiang Zhang , Richard Henderson , Kevin Wolf , qemu-block@nongnu.org, Bastian Koppelmann , Cornelia Huck , Laurent Vivier , Max Reitz , Palmer Dabbelt , xen-devel@lists.xenproject.org, Aurelien Jarno Subject: Re: [PATCH] qemu/atomic.h: prefix qemu_ to solve collisions Message-ID: <20200922081849.GD1989025@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20200921162346.188997-1-stefanha@redhat.com> <52b8a46e-ab9e-1645-163d-497122ece907@redhat.com> <8610ca0e-0b3f-6d95-43b9-e2e49571e311@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8610ca0e-0b3f-6d95-43b9-e2e49571e311@redhat.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Sep 22, 2020 at 08:56:06AM +0200, Paolo Bonzini wrote: > On 22/09/20 08:45, David Hildenbrand wrote: > >> It's certainly a good idea but it's quite verbose. > >> > >> What about using atomic__* as the prefix? It is not very common in QEMU > >> but there are some cases (and I cannot think of anything better). > > > > aqomic_*, lol :) > > Actually qatomic_ would be a good one, wouldn't it? Yes, I think just adding a 'q' on the front of methods is more than sufficient (see also all the qcrypto_*, qio_* APIs I wrote). The only think a plain 'q' prefix is likely to clash with is the Qt library and that isn't something we're likely to link with (famous last words...). Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|