public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: VMX: Explicitly check for hv_remote_flush_tlb when loading pgd()
Date: Fri, 25 Sep 2020 09:24:26 -0700	[thread overview]
Message-ID: <20200925162426.GB31009@linux.intel.com> (raw)
In-Reply-To: <87h7rmch3v.fsf@vitty.brq.redhat.com>

On Fri, Sep 25, 2020 at 11:59:00AM +0200, Vitaly Kuznetsov wrote:
> Sean Christopherson <sean.j.christopherson@intel.com> writes:
> > +#if IS_ENABLED(CONFIG_HYPERV)
> >  	enum ept_pointers_status ept_pointers_match;
> >  	spinlock_t ept_pointer_lock;
> > +#endif
> 
> Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> 
> In case ept_pointers_match/ept_pointer_lock are useless for TDX we may
> want to find better names for them to make it clear this is a Hyper-V
> thingy (e.g. something like hv_tlb_ept_match/hv_tlb_ept_lock).

Good call.  I'll send a v2, looking at hv_remote_flush_tlb_with_range(), I
think there are additional cleanups/optimizations that can be done, e.g. do the
extra flushes only on vCPUs with a mistmatching EPTP instead of flushing all
vCPUs' EPTPs if _any_ vCPU has a mismatched EPTP.

> 
> >  };
> >  
> >  bool nested_vmx_allowed(struct kvm_vcpu *vcpu);
> 
> -- 
> Vitaly
> 

      reply	other threads:[~2020-09-25 16:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-24 18:04 [PATCH] KVM: VMX: Explicitly check for hv_remote_flush_tlb when loading pgd() Sean Christopherson
2020-09-25  9:59 ` Vitaly Kuznetsov
2020-09-25 16:24   ` Sean Christopherson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200925162426.GB31009@linux.intel.com \
    --to=sean.j.christopherson@intel.com \
    --cc=jmattson@google.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox