From: Thomas Huth <thuth@redhat.com>
To: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Cc: Janosch Frank <frankja@linux.ibm.com>
Subject: [kvm-unit-tests PULL 10/11] s390x/selftest: Fix constraint of inline assembly
Date: Mon, 28 Sep 2020 19:49:57 +0200 [thread overview]
Message-ID: <20200928174958.26690-11-thuth@redhat.com> (raw)
In-Reply-To: <20200928174958.26690-1-thuth@redhat.com>
Clang on s390x compains:
/home/thuth/devel/kvm-unit-tests/s390x/selftest.c:39:15: error:
%r0 used in an address
asm volatile(" stg %0,0(%0)\n" : : "r"(-1L));
^
<inline asm>:1:13: note: instantiated into assembly here
stg %r0,0(%r0)
^
Right it is. We should not use address register 0 for STG.
Thus let's use the "a" constraint to avoid register 0 here.
Message-Id: <20200924111746.131633-1-thuth@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
s390x/selftest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/s390x/selftest.c b/s390x/selftest.c
index 4c16646..eaf5b18 100644
--- a/s390x/selftest.c
+++ b/s390x/selftest.c
@@ -36,7 +36,7 @@ static void test_pgm_int(void)
check_pgm_int_code(PGM_INT_CODE_OPERATION);
expect_pgm_int();
- asm volatile(" stg %0,0(%0)\n" : : "r"(-1L));
+ asm volatile(" stg %0,0(%0)\n" : : "a"(-1L));
check_pgm_int_code(PGM_INT_CODE_ADDRESSING);
}
--
2.18.2
next prev parent reply other threads:[~2020-09-28 17:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 17:49 [kvm-unit-tests PULL 00/11] s390x and generic script updates Thomas Huth
2020-09-28 17:49 ` [kvm-unit-tests PULL 01/11] runtime.bash: remove outdated comment Thomas Huth
2020-09-28 17:49 ` [kvm-unit-tests PULL 02/11] Use same test names in the default and the TAP13 output format Thomas Huth
2020-09-28 17:49 ` [kvm-unit-tests PULL 03/11] configure: Add a check for the bash version Thomas Huth
2020-09-28 17:49 ` [kvm-unit-tests PULL 04/11] travis.yml: Update from Bionic to Focal Thomas Huth
2020-09-28 17:49 ` [kvm-unit-tests PULL 05/11] travis.yml: Update the list of s390x tests Thomas Huth
2020-09-28 17:49 ` [kvm-unit-tests PULL 06/11] common.bash: run `cmd` only if a test case was found Thomas Huth
2020-09-28 17:49 ` [kvm-unit-tests PULL 07/11] scripts: add support for architecture dependent functions Thomas Huth
2020-09-28 17:49 ` [kvm-unit-tests PULL 08/11] run_tests/mkstandalone: add arch_cmd hook Thomas Huth
2020-09-28 17:49 ` [kvm-unit-tests PULL 09/11] s390x: add Protected VM support Thomas Huth
2020-09-28 17:49 ` Thomas Huth [this message]
2020-09-28 17:49 ` [kvm-unit-tests PULL 11/11] scripts/arch-run: use ncat rather than nc Thomas Huth
2020-09-29 8:38 ` [kvm-unit-tests PULL 00/11] s390x and generic script updates Paolo Bonzini
2020-09-29 8:47 ` Thomas Huth
2020-09-29 8:49 ` Janosch Frank
2020-09-29 8:58 ` Thomas Huth
2020-09-29 9:06 ` Paolo Bonzini
2020-10-01 9:21 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928174958.26690-11-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox