public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Cc: Janosch Frank <frankja@linux.ibm.com>
Subject: [kvm-unit-tests PULL 11/11] scripts/arch-run: use ncat rather than nc.
Date: Mon, 28 Sep 2020 19:49:58 +0200	[thread overview]
Message-ID: <20200928174958.26690-12-thuth@redhat.com> (raw)
In-Reply-To: <20200928174958.26690-1-thuth@redhat.com>

From: Jamie Iles <jamie@nuviainc.com>

On Red Hat 7+ and derived distributions, 'nc' is nmap-ncat, but on
Debian based distributions this is often netcat-openbsd.  Both are
mostly compatible with the important distinction that netcat-openbsd
does not shutdown the socket on stdin EOF without also passing '-N' as
an argument which is not supported on nmap-ncat.  This has the
unfortunate consequence of hanging qmp calls so tests like aarch64
its-migration never complete.

We're depending on ncat behaviour and nmap-ncat is available in all
major distributions.

Signed-off-by: Jamie Iles <jamie@nuviainc.com>
Message-Id: <20200921103644.1718058-1-jamie@nuviainc.com>
Tested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 scripts/arch-run.bash | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash
index 660f1b7..5997e38 100644
--- a/scripts/arch-run.bash
+++ b/scripts/arch-run.bash
@@ -101,13 +101,13 @@ timeout_cmd ()
 
 qmp ()
 {
-	echo '{ "execute": "qmp_capabilities" }{ "execute":' "$2" '}' | nc -U $1
+	echo '{ "execute": "qmp_capabilities" }{ "execute":' "$2" '}' | ncat -U $1
 }
 
 run_migration ()
 {
-	if ! command -v nc >/dev/null 2>&1; then
-		echo "${FUNCNAME[0]} needs nc (netcat)" >&2
+	if ! command -v ncat >/dev/null 2>&1; then
+		echo "${FUNCNAME[0]} needs ncat (netcat)" >&2
 		return 2
 	fi
 
-- 
2.18.2


  parent reply	other threads:[~2020-09-28 17:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28 17:49 [kvm-unit-tests PULL 00/11] s390x and generic script updates Thomas Huth
2020-09-28 17:49 ` [kvm-unit-tests PULL 01/11] runtime.bash: remove outdated comment Thomas Huth
2020-09-28 17:49 ` [kvm-unit-tests PULL 02/11] Use same test names in the default and the TAP13 output format Thomas Huth
2020-09-28 17:49 ` [kvm-unit-tests PULL 03/11] configure: Add a check for the bash version Thomas Huth
2020-09-28 17:49 ` [kvm-unit-tests PULL 04/11] travis.yml: Update from Bionic to Focal Thomas Huth
2020-09-28 17:49 ` [kvm-unit-tests PULL 05/11] travis.yml: Update the list of s390x tests Thomas Huth
2020-09-28 17:49 ` [kvm-unit-tests PULL 06/11] common.bash: run `cmd` only if a test case was found Thomas Huth
2020-09-28 17:49 ` [kvm-unit-tests PULL 07/11] scripts: add support for architecture dependent functions Thomas Huth
2020-09-28 17:49 ` [kvm-unit-tests PULL 08/11] run_tests/mkstandalone: add arch_cmd hook Thomas Huth
2020-09-28 17:49 ` [kvm-unit-tests PULL 09/11] s390x: add Protected VM support Thomas Huth
2020-09-28 17:49 ` [kvm-unit-tests PULL 10/11] s390x/selftest: Fix constraint of inline assembly Thomas Huth
2020-09-28 17:49 ` Thomas Huth [this message]
2020-09-29  8:38 ` [kvm-unit-tests PULL 00/11] s390x and generic script updates Paolo Bonzini
2020-09-29  8:47   ` Thomas Huth
2020-09-29  8:49   ` Janosch Frank
2020-09-29  8:58     ` Thomas Huth
2020-09-29  9:06       ` Paolo Bonzini
2020-10-01  9:21 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200928174958.26690-12-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox