From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73A6DC4346E for ; Tue, 29 Sep 2020 04:06:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 35B2F20BED for ; Tue, 29 Sep 2020 04:06:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725791AbgI2EGu (ORCPT ); Tue, 29 Sep 2020 00:06:50 -0400 Received: from mga18.intel.com ([134.134.136.126]:18184 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725372AbgI2EGu (ORCPT ); Tue, 29 Sep 2020 00:06:50 -0400 IronPort-SDR: Iat4eEBwGxRTD9sIZw4VB+KGU9elz3tA8oXuPm69E4BSa5wvhr+x8JM4jbVgzUN+sksjgLFnCl 9xqlrGFTvW+g== X-IronPort-AV: E=McAfee;i="6000,8403,9758"; a="149886593" X-IronPort-AV: E=Sophos;i="5.77,317,1596524400"; d="scan'208";a="149886593" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 21:06:49 -0700 IronPort-SDR: ApnA/f/CxUxtFfI6AUY6sarLD5E7WfkcMFTN2TthzC6NyteJVKUwWxGCwmaTT87/ZySyecMLCi 1ayQdCL/bbNg== X-IronPort-AV: E=Sophos;i="5.77,317,1596524400"; d="scan'208";a="488909363" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.160]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 21:06:49 -0700 Date: Mon, 28 Sep 2020 21:06:47 -0700 From: Sean Christopherson To: Krish Sadhukhan Cc: kvm@vger.kernel.org, jmattson@google.com, pbonzini@redhat.com, vkuznets@redhat.com, qemu-devel@nongnu.org Subject: Re: [PATCH 2/6 v3] KVM: SVM: Fill in conforming svm_x86_ops via macro Message-ID: <20200929040647.GJ31514@linux.intel.com> References: <1595895050-105504-1-git-send-email-krish.sadhukhan@oracle.com> <1595895050-105504-3-git-send-email-krish.sadhukhan@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1595895050-105504-3-git-send-email-krish.sadhukhan@oracle.com> User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Jul 28, 2020 at 12:10:46AM +0000, Krish Sadhukhan wrote: > The names of some of the svm_x86_ops functions do not have a corresponding > 'svm_' prefix. Generate the names using a macro so that the names are > conformant. Fixing the naming will help in better readability and > maintenance of the code. I'd probably prefer to split this into two patches, one to rename all the functions and then the second to introduce the autofill macros. Ditto for VMX. > Suggested-by: Vitaly Kuznetsov > Suggested-by: Paolo Bonzini > Signed-off-by: Sean Christopherson All of the patches with my SOB need Co-developed-by: Sean Christopherson > Signed-off-by: Krish Sadhukhan > ---