From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ECA6C4741F for ; Wed, 30 Sep 2020 21:55:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECB152076B for ; Wed, 30 Sep 2020 21:54:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Eb7fqjTg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731045AbgI3Vyq (ORCPT ); Wed, 30 Sep 2020 17:54:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:48040 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730977AbgI3Vyn (ORCPT ); Wed, 30 Sep 2020 17:54:43 -0400 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601502882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R2ALy67CtgBF8fDQMZT8Ir08uhC8QFjLGT5DkxROP8I=; b=Eb7fqjTgLfq0/HNxVhGthll7nCiA+7ujvIKmjV4TR2ZNVQYjbAmkiXZ+XCi6IUXLvkbVi+ VBJW5xSMgJKv0HtT1sAdHTHSVQ6fPo4ntunPtMW7/zBE996PBudyHC2zC7GW9Mo090MNnF B39A+MWbwdMIkT4fIHZje2FRBQf7QeQ= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-509-0rUhSiqoO165xP6CqaZxHw-1; Wed, 30 Sep 2020 17:54:40 -0400 X-MC-Unique: 0rUhSiqoO165xP6CqaZxHw-1 Received: by mail-qk1-f197.google.com with SMTP id m203so1808203qke.16 for ; Wed, 30 Sep 2020 14:54:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R2ALy67CtgBF8fDQMZT8Ir08uhC8QFjLGT5DkxROP8I=; b=mMv3cXL7UIPocC13hVgBQRZJBmWYSgNV6KrAMMbFy248J6A3YX+jV6C9h9s52xdioz GX9bN8c1SkNhycom0ezNrQ32SNAyqAsmF4NHSRpT7oldBh30GuWR+KItqnab6Of9/D+t JyudqqiSp/hE0CfGPY92wu6Vc6rkktN+ZKmTOa5feDgzoFojfG6p+wyLARzNv2Rf7gKb QDtUGveSzYU0XwR1YvnPbAxIdjqVl1fGMkiglmJaffdcw6cLryRzpf16JFnBtcqFX2jv WbhfpKoSAT1AvzmN5IF3Ig8eZI522iG4hkVTqnRGK2QHI7Lc8AioZgG5RcKBe6sysrY2 7vfA== X-Gm-Message-State: AOAM533UXy8EZYOzpuacRjB7tw0tNDIMBiApCqm62uYWexXcCBnsrnJy /57FFhbABjurxyidUkoQb1b43KrKR/dlkfslbfC2PvnjEtuJOkNxoNnjcmLcTJyDeAG2trKK7GP EknDku9aIfiHz X-Received: by 2002:ac8:774f:: with SMTP id g15mr4367687qtu.294.1601502879698; Wed, 30 Sep 2020 14:54:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyo9Y9fPwSdcJ5NaY13SXCpRPPVcNuPIlxZwUDY9BhsBPQWJAurv6M4LALLADYaBZT7tnAjNQ== X-Received: by 2002:ac8:774f:: with SMTP id g15mr4367678qtu.294.1601502879507; Wed, 30 Sep 2020 14:54:39 -0700 (PDT) Received: from xz-x1.redhat.com (toroon474qw-lp130-09-184-147-14-204.dsl.bell.ca. [184.147.14.204]) by smtp.gmail.com with ESMTPSA id t43sm4126963qtc.54.2020.09.30.14.54.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2020 14:54:38 -0700 (PDT) From: Peter Xu To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andrew Jones , Sean Christopherson , Paolo Bonzini , "Dr . David Alan Gilbert" , peterx@redhat.com Subject: [PATCH v12 07/13] KVM: selftests: Always clear dirty bitmap after iteration Date: Wed, 30 Sep 2020 17:54:37 -0400 Message-Id: <20200930215437.48102-1-peterx@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200930214948.47225-1-peterx@redhat.com> References: <20200930214948.47225-1-peterx@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org We don't clear the dirty bitmap before because KVM_GET_DIRTY_LOG will clear it for us before copying the dirty log onto it. However we'd still better to clear it explicitly instead of assuming the kernel will always do it for us. More importantly, in the upcoming dirty ring tests we'll start to fetch dirty pages from a ring buffer, so no one is going to clear the dirty bitmap for us. Reviewed-by: Andrew Jones Signed-off-by: Peter Xu --- tools/testing/selftests/kvm/dirty_log_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/dirty_log_test.c b/tools/testing/selftests/kvm/dirty_log_test.c index 752ec158ac59..6a8275a22861 100644 --- a/tools/testing/selftests/kvm/dirty_log_test.c +++ b/tools/testing/selftests/kvm/dirty_log_test.c @@ -195,7 +195,7 @@ static void vm_dirty_log_verify(enum vm_guest_mode mode, unsigned long *bmap) page); } - if (test_bit_le(page, bmap)) { + if (test_and_clear_bit_le(page, bmap)) { host_dirty_count++; /* * If the bit is set, the value written onto -- 2.26.2