From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09D14C388F9 for ; Mon, 26 Oct 2020 16:46:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ABF5F221FC for ; Mon, 26 Oct 2020 16:46:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="g//QpqXg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1786321AbgJZQqT (ORCPT ); Mon, 26 Oct 2020 12:46:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:43574 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1786296AbgJZQo6 (ORCPT ); Mon, 26 Oct 2020 12:44:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603730696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CDvVG7SgoIbQgh16s2cy5auVhz6YGJQM9U9q07y74fs=; b=g//QpqXgrqlfYZrRTAe8QwM4kgzS6Ttw6BW8zdfP7GDbOK8iKwcXsDv55aJGYRCWArUghK TB5UcnaGrcEmJH7hAkkVkMzYeEfZRa/BEIwU9h8lYWg3d4v/peaGqYLoqCSTHBV8NGYbdp 670d+kPs+9F5zY4nA6y0n0EQ69TQsVg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-238-tqOogWUKOOq41NPdmBoafA-1; Mon, 26 Oct 2020 12:44:52 -0400 X-MC-Unique: tqOogWUKOOq41NPdmBoafA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0AE5785B683; Mon, 26 Oct 2020 16:44:51 +0000 (UTC) Received: from gondolin (ovpn-113-108.ams2.redhat.com [10.36.113.108]) by smtp.corp.redhat.com (Postfix) with ESMTP id 298B660C13; Mon, 26 Oct 2020 16:44:29 +0000 (UTC) Date: Mon, 26 Oct 2020 17:44:26 +0100 From: Cornelia Huck To: Matthew Rosato Cc: thuth@redhat.com, pmorel@linux.ibm.com, schnelle@linux.ibm.com, rth@twiddle.net, david@redhat.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, mst@redhat.com, pbonzini@redhat.com, alex.williamson@redhat.com, philmd@redhat.com, qemu-s390x@nongnu.org, qemu-devel@nongnu.org, kvm@vger.kernel.org Subject: Re: [PATCH 00/13] s390x/pci: s390-pci updates for kernel 5.10-rc1 Message-ID: <20201026174426.7072fdcd.cohuck@redhat.com> In-Reply-To: References: <1603726481-31824-1-git-send-email-mjrosato@linux.ibm.com> <20201026171947.0f302dcc.cohuck@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, 26 Oct 2020 12:38:45 -0400 Matthew Rosato wrote: > On 10/26/20 12:19 PM, Cornelia Huck wrote: > > On Mon, 26 Oct 2020 11:34:28 -0400 > > Matthew Rosato wrote: > > > >> Combined set of patches that exploit vfio/s390-pci features available in > >> kernel 5.10-rc1. This patch set is a combination of > >> > >> [PATCH v4 0/5] s390x/pci: Accomodate vfio DMA limiting > >> > >> and > >> > >> [PATCH v3 00/10] Retrieve zPCI hardware information from VFIO > >> > >> with duplicate patches removed and a single header sync. All patches have > >> prior maintainer reviews except for: > >> > >> - Patch 1 (update-linux-headers change to add new file) > > > > That one has ;) > > > >> - Patch 2 (header sync against 5.10-rc1) > > > > I'm still unsure about the rdma/(q)atomic stuff -- had we reached any > > conclusion there? > > Ugh, I forgot about this... I had CC'd the associated maintainers a few > times but never heard back from anyone on how to resolve this. > > Paolo said previously this stuff should not have been imported by a > header sync in the first place > (https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg00734.html), > so I would guess that the proper fix is to stop importing the rdma stuff > and (re)define it somewhere in QEMU. I think so. > > We could just drop the rmda file hit from this sync, but it's going to > keep happening until the code is removed from the kernel header. Yeah. It's unfortunate that 5.10-rc1 and the soft freeze are so close together :( > > > > >> - Patch 13 - contains a functional (debug) change; I switched from using > >> DPRINTFs to using trace events per Connie's request. > >> > >> > >> > >> Matthew Rosato (10): > >> update-linux-headers: Add vfio_zdev.h > >> linux-headers: update against 5.10-rc1 > >> s390x/pci: Move header files to include/hw/s390x > >> vfio: Create shared routine for scanning info capabilities > >> vfio: Find DMA available capability > >> s390x/pci: Add routine to get the vfio dma available count > >> s390x/pci: Honor DMA limits set by vfio > >> s390x/pci: clean up s390 PCI groups > >> vfio: Add routine for finding VFIO_DEVICE_GET_INFO capabilities > >> s390x/pci: get zPCI function info from host > >> > >> Pierre Morel (3): > >> s390x/pci: create a header dedicated to PCI CLP > >> s390x/pci: use a PCI Group structure > >> s390x/pci: use a PCI Function structure > >> > >> MAINTAINERS | 1 + > >> hw/s390x/meson.build | 1 + > >> hw/s390x/s390-pci-bus.c | 91 ++++++- > >> hw/s390x/s390-pci-inst.c | 78 ++++-- > >> hw/s390x/s390-pci-vfio.c | 276 +++++++++++++++++++++ > >> hw/s390x/s390-virtio-ccw.c | 2 +- > >> hw/s390x/trace-events | 6 + > >> hw/vfio/common.c | 62 ++++- > >> {hw => include/hw}/s390x/s390-pci-bus.h | 22 ++ > >> .../hw/s390x/s390-pci-clp.h | 123 +-------- > >> include/hw/s390x/s390-pci-inst.h | 119 +++++++++ > >> include/hw/s390x/s390-pci-vfio.h | 23 ++ > >> include/hw/vfio/vfio-common.h | 4 + > >> .../drivers/infiniband/hw/vmw_pvrdma/pvrdma_ring.h | 14 +- > >> .../infiniband/hw/vmw_pvrdma/pvrdma_verbs.h | 2 +- > >> include/standard-headers/linux/ethtool.h | 2 + > >> include/standard-headers/linux/fuse.h | 50 +++- > >> include/standard-headers/linux/input-event-codes.h | 4 + > >> include/standard-headers/linux/pci_regs.h | 6 +- > >> include/standard-headers/linux/virtio_fs.h | 3 + > >> include/standard-headers/linux/virtio_gpu.h | 19 ++ > >> include/standard-headers/linux/virtio_mmio.h | 11 + > >> include/standard-headers/linux/virtio_pci.h | 11 +- > >> linux-headers/asm-arm64/kvm.h | 25 ++ > >> linux-headers/asm-arm64/mman.h | 1 + > >> linux-headers/asm-generic/hugetlb_encode.h | 1 + > >> linux-headers/asm-generic/unistd.h | 18 +- > >> linux-headers/asm-mips/unistd_n32.h | 1 + > >> linux-headers/asm-mips/unistd_n64.h | 1 + > >> linux-headers/asm-mips/unistd_o32.h | 1 + > >> linux-headers/asm-powerpc/unistd_32.h | 1 + > >> linux-headers/asm-powerpc/unistd_64.h | 1 + > >> linux-headers/asm-s390/unistd_32.h | 1 + > >> linux-headers/asm-s390/unistd_64.h | 1 + > >> linux-headers/asm-x86/kvm.h | 20 ++ > >> linux-headers/asm-x86/unistd_32.h | 1 + > >> linux-headers/asm-x86/unistd_64.h | 1 + > >> linux-headers/asm-x86/unistd_x32.h | 1 + > >> linux-headers/linux/kvm.h | 19 ++ > >> linux-headers/linux/mman.h | 1 + > >> linux-headers/linux/vfio.h | 29 ++- > >> linux-headers/linux/vfio_zdev.h | 78 ++++++ > >> scripts/update-linux-headers.sh | 2 +- > >> 43 files changed, 961 insertions(+), 173 deletions(-) > >> create mode 100644 hw/s390x/s390-pci-vfio.c > >> rename {hw => include/hw}/s390x/s390-pci-bus.h (94%) > >> rename hw/s390x/s390-pci-inst.h => include/hw/s390x/s390-pci-clp.h (59%) > >> create mode 100644 include/hw/s390x/s390-pci-inst.h > >> create mode 100644 include/hw/s390x/s390-pci-vfio.h > >> create mode 100644 linux-headers/linux/vfio_zdev.h > >> > > >