From: Peter Xu <peterx@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
Takashi Iwai <tiwai@suse.de>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Sean Christopherson <sean.j.christopherson@intel.com>,
Steffen Dirkwinkel <kernel-bugs@steffen.cc>
Subject: Re: [PATCH 2/2] KVM: X86: Fix null pointer reference for KVM_GET_MSRS
Date: Sat, 31 Oct 2020 11:27:46 -0400 [thread overview]
Message-ID: <20201031152746.GE6357@xz-x1> (raw)
In-Reply-To: <c20d7c85-b2f3-608a-833f-093363fac5f5@redhat.com>
On Sat, Oct 31, 2020 at 03:06:59PM +0100, Paolo Bonzini wrote:
> > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> > index ce856e0ece84..5993fbd6d2c5 100644
> > --- a/arch/x86/kvm/x86.c
> > +++ b/arch/x86/kvm/x86.c
> > @@ -259,8 +259,8 @@ static int kvm_msr_ignored_check(struct kvm_vcpu *vcpu, u32 msr,
> >
> > if (ignore_msrs) {
> > if (report_ignored_msrs)
> > - vcpu_unimpl(vcpu, "ignored %s: 0x%x data 0x%llx\n",
> > - op, msr, data);
> > + kvm_pr_unimpl("ignored %s: 0x%x data 0x%llx\n",
> > + op, msr, data);
> > /* Mask the error */
> > return 0;
> > } else {
> >
>
> I committed Takashi Iwai's very similar patch. Please resend 1/2 with
> reviewer comments addressed, thanks!
Sorry for a late reply (to reviewers).
Oh, how did I miss the other vcpu reference... that one is definitely better. :)
Will respin shortly on the test.
Thanks,
--
Peter Xu
prev parent reply other threads:[~2020-10-31 15:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-25 18:53 [PATCH 0/2] Fix null pointer dereference in kvm_msr_ignored_check Peter Xu
2020-10-25 18:53 ` [PATCH 1/2] KVM: selftests: Add get featured msrs test case Peter Xu
2020-10-26 8:58 ` Vitaly Kuznetsov
2020-10-26 9:08 ` Andrew Jones
2020-10-31 15:34 ` Peter Xu
2020-10-25 18:53 ` [PATCH 2/2] KVM: X86: Fix null pointer reference for KVM_GET_MSRS Peter Xu
2020-10-26 9:07 ` Vitaly Kuznetsov
2020-10-31 14:06 ` Paolo Bonzini
2020-10-31 15:27 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201031152746.GE6357@xz-x1 \
--to=peterx@redhat.com \
--cc=kernel-bugs@steffen.cc \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tiwai@suse.de \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox