From: Cornelia Huck <cohuck@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>
Cc: kvm@vger.kernel.org, david@redhat.com, thuth@redhat.com,
linux-s390@vger.kernel.org, borntraeger@de.ibm.com,
imbrenda@linux.ibm.com
Subject: Re: [PATCH] kvm: s390: pv: Mark mm as protected after the set secure parameters and improve cleanup
Date: Tue, 10 Nov 2020 12:31:05 +0100 [thread overview]
Message-ID: <20201110123105.4b7b1235.cohuck@redhat.com> (raw)
In-Reply-To: <20201030140141.106641-1-frankja@linux.ibm.com>
On Fri, 30 Oct 2020 10:01:41 -0400
Janosch Frank <frankja@linux.ibm.com> wrote:
> We can only have protected guest pages after a successful set secure
> parameters call as only then the UV allows imports and unpacks.
>
> By moving the test we can now also check for it in s390_reset_acc()
> and do an early return if it is 0.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> arch/s390/kvm/kvm-s390.c | 2 +-
> arch/s390/kvm/pv.c | 3 ++-
> arch/s390/mm/gmap.c | 2 ++
> 3 files changed, 5 insertions(+), 2 deletions(-)
Seems reasonable to me. I assume it has been given some coverage by now?
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
prev parent reply other threads:[~2020-11-10 11:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 14:01 [PATCH] kvm: s390: pv: Mark mm as protected after the set secure parameters and improve cleanup Janosch Frank
2020-10-30 14:23 ` Christian Borntraeger
2020-11-11 8:17 ` Janosch Frank
2020-11-11 8:26 ` Christian Borntraeger
2020-10-30 14:25 ` Christian Borntraeger
2020-10-30 14:31 ` Janosch Frank
2020-11-10 11:31 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110123105.4b7b1235.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox