From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D05D0C4361A for ; Fri, 4 Dec 2020 12:59:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 86EE5224F4 for ; Fri, 4 Dec 2020 12:59:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730239AbgLDM6q (ORCPT ); Fri, 4 Dec 2020 07:58:46 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:29048 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729128AbgLDM6q (ORCPT ); Fri, 4 Dec 2020 07:58:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607086640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e2n1oh4DvD0ZoyVsf8H0hUYTOFg8vSGC6lf8R25dVKo=; b=PFg5itv84ZrBmO1apzLdcQpdELMqbd699BPc1MPeOMNMLqmdrLP4q7s7yuAf5AGvQpNA0v mfZEX4MCE+Bm6gz/vkERRbsWbsKizPUEKYHlBZJxOk9xhCQGnwpwvpJcp6jC1/lelFu/nX Ax8UT1douh06USa7uJsKDjjY5yhCvwU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-168-HW980yUnOJG3P3Gk44aoFw-1; Fri, 04 Dec 2020 07:57:18 -0500 X-MC-Unique: HW980yUnOJG3P3Gk44aoFw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 262D1107ACE4; Fri, 4 Dec 2020 12:57:15 +0000 (UTC) Received: from gondolin (ovpn-113-97.ams2.redhat.com [10.36.113.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1F38F60C17; Fri, 4 Dec 2020 12:57:04 +0000 (UTC) Date: Fri, 4 Dec 2020 13:57:02 +0100 From: Cornelia Huck To: David Gibson Cc: pair@us.ibm.com, pbonzini@redhat.com, frankja@linux.ibm.com, brijesh.singh@amd.com, dgilbert@redhat.com, qemu-devel@nongnu.org, Eduardo Habkost , qemu-ppc@nongnu.org, rth@twiddle.net, thuth@redhat.com, berrange@redhat.com, mdroth@linux.vnet.ibm.com, Marcelo Tosatti , "Michael S. Tsirkin" , Marcel Apfelbaum , david@redhat.com, Richard Henderson , borntraeger@de.ibm.com, kvm@vger.kernel.org, qemu-s390x@nongnu.org, pasic@linux.ibm.com, Greg Kurz Subject: Re: [for-6.0 v5 01/13] qom: Allow optional sugar props Message-ID: <20201204135702.3b4a0b5f.cohuck@redhat.com> In-Reply-To: <20201204054415.579042-2-david@gibson.dropbear.id.au> References: <20201204054415.579042-1-david@gibson.dropbear.id.au> <20201204054415.579042-2-david@gibson.dropbear.id.au> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, 4 Dec 2020 16:44:03 +1100 David Gibson wrote: > From: Greg Kurz > > Global properties have an @optional field, which allows to apply a given > property to a given type even if one of its subclasses doesn't support > it. This is especially used in the compat code when dealing with the > "disable-modern" and "disable-legacy" properties and the "virtio-pci" > type. > > Allow object_register_sugar_prop() to set this field as well. > > Signed-off-by: Greg Kurz > Message-Id: <159738953558.377274.16617742952571083440.stgit@bahia.lan> > Signed-off-by: David Gibson > --- > include/qom/object.h | 3 ++- > qom/object.c | 4 +++- > softmmu/vl.c | 16 ++++++++++------ > 3 files changed, 15 insertions(+), 8 deletions(-) Reviewed-by: Cornelia Huck